Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapt to mc#1256 #1379

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

adapt to mc#1256 #1379

wants to merge 1 commit into from

Conversation

Tragicus
Copy link
Collaborator

@Tragicus Tragicus commented Nov 4, 2024

Motivation for this change

math-comp/math-comp#1256 defines some structures on dependent function types, which requires a few rewrites (for things that do not unfold automatically) and annotations (to convince the unification algorithm).
There is bad interaction with tvs.v. When I have R : numFieldType, I can check that R is a topologicalType and a zmodType, but not a TopologicalZmodule.type, and when I try to make HB compute the missing instances, it complains about non_forgetful_inheritance.

Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers

Reference: How to document

Reminder to reviewers

@proux01
Copy link
Collaborator

proux01 commented Nov 4, 2024

The title / commit message says mc#1169 but the top message mentions mc#1256 ?

@Tragicus Tragicus changed the title adapt to mc#1169 adapt to mc#1256 Nov 4, 2024
@Tragicus
Copy link
Collaborator Author

Tragicus commented Nov 4, 2024

I can not change the name of the branch, so let's pretend that it has the right name, all the rest should be fixed.

@Tragicus Tragicus marked this pull request as draft November 5, 2024 15:22
@Tragicus Tragicus force-pushed the pr1169 branch 2 times, most recently from 2839d05 to 2a28b10 Compare November 25, 2024 15:20
@Tragicus
Copy link
Collaborator Author

I removed the instances on dependent functions from math-comp/math-comp#1256. There is only a bad interaction with tvs left. When I have R : numFieldType, I can check that R is a topologicalType and a zmodType, but not a TopologicalZmodule.type, and when I try to make HB compute the missing instances, it complains about non_forgetful_inheritance.

@Tragicus Tragicus marked this pull request as ready for review November 25, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants