Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
math-comp/math-comp#1256 defines some structures on dependent function types, which requires a few rewrites (for things that do not unfold automatically) and annotations (to convince the unification algorithm).There is bad interaction with
tvs.v
. When I have R : numFieldType, I can check that R is atopologicalType
and azmodType
, but not aTopologicalZmodule.type
, and when I try to makeHB
compute the missing instances, it complains aboutnon_forgetful_inheritance
.Checklist
CHANGELOG_UNRELEASED.md
Reference: How to document
Reminder to reviewers