Please review my PR, suggest changes if any. #1
Conversation
There was a problem hiding this comment.
mechanical design directory structure should be according to guidelines. for e.g. Mechanical design
Report and Poster
README.md
Outdated
| - It has a large number of pins, hence all the sensors and motors can | ||
| be connected easily. | ||
|
|
There was a problem hiding this comment.
there should not be any spaces between two bulleted points
| ## **Workflow** | ||
|
|
||
| <p align="center"><img src="https://github.com/kai-013/eWaste-Dustbin/blob/kai-013-patch-1/Images%20and%20Videos/Images/WORKFLOW/Workflow.JPG" width="6000px" height="900px"/></p> |
There was a problem hiding this comment.
size of images can be decreased, and this should be same for all of the images
updated readme file
Update 2 README.md
Update README.md
|
@Nageshbansal sir changes were made. Please merge it, if it is final. |
src/object detection.py
Outdated
| # In[1]: | ||
|
|
||
|
|
||
| get_ipython().system('pip install torch==1.8.1+cu111 torchvision==0.9.1+cu111 torchaudio===0.8.1 -f https://download.pytorch.org/whl/lts/1.8/torch_lts.html') |
There was a problem hiding this comment.
I guess you're trying to convert the .ipynb to .py file, it's fine you can just put the .ipynb ( jupyter file) instead of converting it.
There was a problem hiding this comment.
@ShreyaMittalSM, resolve this conversation ASAP, so that i can merge your PR.
|
LGTM |
|
@Nageshbansal sir, changes were made. |
There was a problem hiding this comment.
@ShreyaMittalSM @kai-013 @Aastha-tembhare @jiteshbhati305 Repo is well structured. Following changes are expected.
- In poster, Add IITR logo, add "Models and Robotics Section IITR", remove "sir" in mentors' list, arrange mentors and team members name in alphabetical order.
- In report, add "Models and Robotics Section IITR"
- In README.md, justify the text content.
@Nageshbansal Follow this up
| appealing. | ||
|
|
||
| ## **Team Members** |
There was a problem hiding this comment.
Team members' name need to be arranged in alphabetical order
|
@ShreyaMittalSM @jiteshbhati305 , let me know when you're done with the requested changes. |
Update4 README.md
|
@Nageshbansal sir, changes are done. |
|
Good Work, now let's squash the commits as there are 100+ commits and some of them include small changes. Let me know when you're free so we can work on this together. |
No description provided.