Add support for admin configuration through props instead of elements #8944
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There are rules dictating the allowed children for the
Admin
components because those are configuration elements. You can't just pass any react elements. This is in part because that's how React Router works when you favor JSX for your routing configuration.This can come as a surprise for newcomers as you actually have to read the documentation to know about them.
Solution
You can now pass your resources and custom routes as objects through the admin props. This make them explicit (
resources
,customRoutes
andcustomRoutesWithoutLayout
) and discoverable via your IDE autocompletion.It looks like this:
TODO