Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM] [Storybook] Re-enable storysource addon #10363

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

slax57
Copy link
Contributor

@slax57 slax57 commented Nov 20, 2024

Problem

Storybook storysource addon (allowing to display the source code for a story in the 'Code' panel) was broken since we updated to Storybook v8.

It would be nice to re-enable it to allow viewers of our storybook to also view the matching source code.

Solution

I actually managed to track down a bug in Storybook, preventing this addon to work in the first place.

This PR re-enables the plugin, and is to be merged when the issue is fixed in a new storybook release.

Blocked: wait until storybookjs/storybook#29669 is merged and released

How To Test

Run storybook, and check the source code of each story is present in the 'Code' panel.

Additional Checks

  • The PR targets master for a bugfix, or next for a feature
  • The PR includes unit tests (if not possible, describe why)
  • The PR includes one or several stories (if not possible, describe why)
  • The documentation is up to date

Also, please make sure to read the contributing guidelines.

@slax57 slax57 added WIP Work In Progress DNM Do Not Merge labels Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DNM Do Not Merge WIP Work In Progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant