Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SimpleList] deprecate linkType, and implement rowClick as for the DataGrid #10349

Open
wants to merge 96 commits into
base: next
Choose a base branch
from

Conversation

quentin-decre
Copy link
Contributor

Problem

The linkType for SimpleList provides less functionality than the rowClick for DataGrid. And also the inconsistency makes it harder to use.

Solution

Implement rowClick prop as it works for Datagrid.
Keep the linkType prop working as previously, but show it as deprecated. If both are set, linkType takes precedence (because it will be simpler to remove from the code later that way).

How To Test

Similar to data grid

Additional Checks

  • The PR targets master for a bugfix, or next for a feature
  • The PR includes unit tests (if not possible, describe why)
  • The PR includes one or several stories (if not possible, describe why)
  • The documentation is up to date

Copy link
Collaborator

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is a new feature though. Can you target the next branch?

React-Admin CI and others added 26 commits November 13, 2024 10:38
@quentin-decre
Copy link
Contributor Author

Thanks! This is a new feature though. Can you target the next branch?

J'ai rebase sur next et changé la target, mais je ne comprends pas pourquoi il met autant de diff. Ce sont bien des commits qui sont déjà sur next non ?

@erwanMarmelab
Copy link
Contributor

Thanks! This is a new feature though. Can you target the next branch?

J'ai rebase sur next et changé la target, mais je ne comprends pas pourquoi il met autant de diff. Ce sont bien des commits qui sont déjà sur next non ?

@quentin-decre

Malheuresement non. Comme vous pouvez le voir dans le CHANGELOG de la branche next, la dernière version est la 5.3.0 contrairement au CHANGELOG présent dans votre branche qui va jusqu'à la version 5.3.3 (comme le CHANGELOG de la branche master).

Pourriez-vous recréer une nouvelle branche (basée sur master) et faire un cherry-pick de vos commits ?

@djhi
Copy link
Collaborator

djhi commented Nov 21, 2024

We just merged master on next, can you rebase?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.