-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SimpleList] deprecate linkType, and implement rowClick as for the DataGrid #10349
base: next
Are you sure you want to change the base?
[SimpleList] deprecate linkType, and implement rowClick as for the DataGrid #10349
Conversation
270c3b6
to
ede21f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This is a new feature though. Can you target the next
branch?
This reverts commit 58edc9c.
…dy exist when createLabel is provided
Co-authored-by: Jean-Baptiste Kaiser <[email protected]>
…oning its children
…houldUnregister in React.StrictMode
Signed-off-by: Emmanuel Ferdman <[email protected]>
ede21f4
to
6ca2f0d
Compare
J'ai rebase sur next et changé la target, mais je ne comprends pas pourquoi il met autant de diff. Ce sont bien des commits qui sont déjà sur next non ? |
Malheuresement non. Comme vous pouvez le voir dans le CHANGELOG de la branche Pourriez-vous recréer une nouvelle branche (basée sur |
We just merged master on next, can you rebase? |
Problem
The linkType for SimpleList provides less functionality than the rowClick for DataGrid. And also the inconsistency makes it harder to use.
Solution
Implement rowClick prop as it works for Datagrid.
Keep the linkType prop working as previously, but show it as deprecated. If both are set, linkType takes precedence (because it will be simpler to remove from the code later that way).
How To Test
Similar to data grid
Additional Checks
master
for a bugfix, ornext
for a feature