-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
not add space character for CJK. #353
base: master
Are you sure you want to change the base?
Conversation
It is not necessary to open a new PR every time, just push new commits to your branch, the PR will get updated automatically. |
Thanks.I try to rebase my new commit on top of your current master. and check whether the PR will get updated automatically. |
Please open one PR per feature |
How to open one PR per feature |
Make one branch per feature |
why not github give a button to split PR |
Because it would have to create two separate branches anyways to satisfy the git workflow, so you can just as well create the branches yourself. |
you are right |
Could you answer the question from PR #351: So as I understand, you decide to add a space between to words if |
Yes, you are right. I have changed the detect method as you said, determined it based on the last character of the left-word and the first character of the right word. |
There are still many uneeded spaces. |
2881b55
to
1b5c448
Compare
What's the status of this PR? Looks like it hasn't been active for 3 years... |
779852a
to
1daebd1
Compare
No description provided.