Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not add space character for CJK. #353

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

napasa
Copy link

@napasa napasa commented Jun 22, 2018

No description provided.

@manisandro
Copy link
Owner

It is not necessary to open a new PR every time, just push new commits to your branch, the PR will get updated automatically.

@napasa
Copy link
Author

napasa commented Jun 22, 2018

Thanks.I try to rebase my new commit on top of your current master. and check whether the PR will get updated automatically.

@manisandro
Copy link
Owner

Please open one PR per feature

@napasa
Copy link
Author

napasa commented Jun 25, 2018

How to open one PR per feature

@manisandro
Copy link
Owner

Make one branch per feature

@napasa
Copy link
Author

napasa commented Jun 25, 2018

why not github give a button to split PR

@manisandro
Copy link
Owner

Because it would have to create two separate branches anyways to satisfy the git workflow, so you can just as well create the branches yourself.

@napasa
Copy link
Author

napasa commented Jun 26, 2018

you are right

@manisandro
Copy link
Owner

Could you answer the question from PR #351:

So as I understand, you decide to add a space between to words if Utils::SpacedWord returns true for both the left and the right word. But Utils::SpacedWord only checks the first character of a word. Does this make sense? Isn't it better to determine whether to add a space based on the last character of the left word and the first character of the right word (in the case of left-to-right text)?

@napasa
Copy link
Author

napasa commented Jun 29, 2018

Yes, you are right. I have changed the detect method as you said, determined it based on the last character of the left-word and the first character of the right word.

@YangtseSu
Copy link

There are still many uneeded spaces.

@manisandro manisandro force-pushed the master branch 2 times, most recently from 2881b55 to 1b5c448 Compare July 8, 2021 20:40
@dogtopus
Copy link

What's the status of this PR? Looks like it hasn't been active for 3 years...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants