rogue: solve build errors on Sequoia #26723
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add patch for build errors and warnings * add sha256, rmd160 checksum to Portfile Closes: https://trac.macports.org/ticket/70909
herbygillot
reviewed
Nov 25, 2024
| @@ -21,14 +21,21 @@ homepage http://rogue.rogueforge.net | |||
| master_sites ${homepage}/files/rogue5.4/ | |||
|
|
|||
| checksums md5 033288f46444b06814c81ea69d96e075 \ | |||
| sha1 aef9e589c4f31eb6d3eeb9d543ab8787b00fb022 | |||
| sha1 aef9e589c4f31eb6d3eeb9d543ab8787b00fb022 \ | |||
There was a problem hiding this comment.
Both md5 and sha1 are legacy checksum types we no longer want to continue using going forward, so we can drop those 2.
There was a problem hiding this comment.
Ok, I'll remove them
|
Thank you for this submission, @dagui0. Just one comment. Can you amend your existing commit? |
|
I can't amend to this commit because of same line is edited. I'll close this and submit another pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: https://trac.macports.org/ticket/70909
Description
Type(s)
Tested on
macOS 15.1.1 24B91 x86_64
Xcode 16.1 16B40
Verification
Have you
port lint --nitpick?sudo port test?sudo port -vst install?