Add iperf network test #777
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidchisnall
approved these changes
Aug 13, 2020
davidchisnall
added a commit
that referenced
this pull request
Aug 13, 2020
The code instructing the polling thread to poll had a race condition that meant that sometimes the polling thread would poll only for reads or writes (or neither, just for subsequent wake-ups). With this, the iperf test in #777 runs to completion with an average of around 3Gb/s. Fixes #681 Related to #499
paulcallen
approved these changes
Aug 13, 2020
SeanTAllen
pushed a commit
that referenced
this pull request
Aug 14, 2020
The code instructing the polling thread to poll had a race condition that meant that sometimes the polling thread would poll only for reads or writes (or neither, just for subsequent wake-ups). With this, the iperf test in #777 runs to completion with an average of around 3Gb/s. Fixes #681 Related to #499
SeanTAllen
pushed a commit
that referenced
this pull request
Aug 14, 2020
The code instructing the polling thread to poll had a race condition that meant that sometimes the polling thread would poll only for reads or writes (or neither, just for subsequent wake-ups). With this, the iperf test in #777 runs to completion with an average of around 3Gb/s. Fixes #681 Related to #499
SeanTAllen
pushed a commit
that referenced
this pull request
Aug 14, 2020
The code instructing the polling thread to poll had a race condition that meant that sometimes the polling thread would poll only for reads or writes (or neither, just for subsequent wake-ups). With this, the iperf test in #777 runs to completion with an average of around 3Gb/s. Fixes #681 Related to #499
This test is still broken due to #499 and deactivated by default.
prp
force-pushed
the
prp/add_iperf_test
branch
from
666c043
to
72b6989
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test depends on PR #781 being merged.