fix: Policies always deny #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nated. This fix also resolves loft-sh#9.
|
This PR also solves the same issue, but slightly different solution: #10 (open for 2 years...) |
merusso
approved these changes
Sep 6, 2024
|
@LukasGentele or @FabianKramm, could you please take a look? This fixes a pretty old bug in the SDK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are no errors, the
combinedErrorsarray will consist of empty arrays:[ [], [], ..., [] ]. Consequently, the conditioncombinedErrors.length > 0will always evaluate to true, as the length ofcombinedErrorsequals the number of inner arrays, thereby triggering the denial of the request.In this pull request, I'm utilizing the
errors.flat()method, which returns a new array with its sub-array elements concatenated into it. This ensures that when no error is present,combinedErrorswill be equal to an empty array[], while when errors are present, it will contain strings like "error 1","error 2", ..., "error n".This fix also resolves #9.