Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unable to play the recorded video in the record activilty #1664

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

yashveeeeer
Copy link

fixing issue #1203 and #1661

@yashveeeeer
Copy link
Author

@llaske would you please review it.

@llaske
Copy link
Owner

llaske commented Oct 12, 2024

Smart fix. Thanks.
Did you had opportunity to test on others operating system than Windows?
As you know, Sugarizer is multi-platform so the fix should work on every platform.
I've read that VP8 has broader compatibility, especially in older devices and software. May be it could be better to use VP8 than VP9.

@yashveeeeer
Copy link
Author

Thanks @llaske, Yeah I will try to see the fix on different OS using Virtual Machine.
and you are right about VP8 has broader compatibility on older devices than VP9, I just read that , I will change it to that after checking the fix on different OS.

@yashveeeeer
Copy link
Author

yashveeeeer commented Oct 15, 2024

kindly ignore that force push, it was done mistakenly truth is I was trying something
I have changed VP9 to VP8, I have also check the fix on Linux.
actually the video player is working fine in Linux, the problem is only with the windows environment, when I added the fix the video was still working fine with Linux.

@llaske llaske merged commit 11afcc1 into llaske:dev Oct 15, 2024
@llaske
Copy link
Owner

llaske commented Oct 15, 2024

Thanks a lot for fixing this very old bug.

@yashveeeeer
Copy link
Author

My pleasure, I learned a lot, from this bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants