-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add auto completion for parameters values && args #149
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Vr00mm <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the changes! 🚀
Signed-off-by: deep-poharkar <[email protected]>
* fixed the compatibility matrix Signed-off-by: deep-poharkar <[email protected]> * fixed AuthResponse snake case to camelCase Signed-off-by: deep-poharkar <[email protected]> --------- Signed-off-by: deep-poharkar <[email protected]>
Signed-off-by: jongwooo <[email protected]>
* Update Upgrade Command Signed-off-by: nagesh bansal <[email protected]> * Rename ops/ and types/agent_types.go Signed-off-by: nagesh bansal <[email protected]> * Add Usage_0.23.0.md link in Readme Signed-off-by: nagesh bansal <[email protected]> --------- Signed-off-by: nagesh bansal <[email protected]>
* Added changes for 0.24 release Signed-off-by: Sarthak Jain <[email protected]> * minor changes Signed-off-by: Sarthak Jain <[email protected]> --------- Signed-off-by: Sarthak Jain <[email protected]>
@Vr00mm , the PR looks good, can you please resolve the conflicts so that we can merge it |
@Vr00mm have you tested the describe chaos-experiment command? It works with chaos experiment ID and project ID, and not with the chaos experiment name |
Hello, iam trying to do it today ! |
Signed-off-by: Rémi ZIOLKOWSKI <[email protected]>
@Vr00mm can you please sign the commits, we will not be able to merge it without that |
Arf sorry, It was the merge from your repo to mine. Iam fixing it. |
I dont know why we have this blocking @SarthakJain26 all 3 commits are signed: Can we just re-run de pipeline ? |
@Vr00mm Github is not showing that the commits are signed so we can't merge. Maybe you can try interactive rebase to sign the older commits by running this command:
where |
Signed-off-by: Rémi ZIOLKOWSKI <[email protected]>
30070a0
to
51e2f80
Compare
Ok iam done for today, i fked the repo. |
Hey @Vr00mm, Are you still working on this? Feel free to let us know if you need any help with it. |
Add completion for parameters values.
--project-id, Fetch projects from instance.
--experiment-id, Fetch experiments from instance. (project-id flag need to be set)
--chaos-infra-id, Fetch infrasID from instance. (project-id flag need to be set)
--chaos-infra, Fetch infrasID from instance. (project-id flag need to be set)
--output, values are "json", "yaml"
--installation-mode, values are "cluster", "namespace"
--type, values are "cluster", "namespace"
--platform-name, values are "AWS", "GKE", "Openshift", "Rancher", "Others"
--chaos-infra-type, values are "external", "internal"
I added the completion for those parameters on all commands.
Add completion for args.
litmus describe|save chaos-experiment
I tested the completion on bash only.
For bash:
For others, check the cobra completion doc: