Add prometheus-cpp for Prometheus Metrics #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am a bot, here are the test results for this PR:
|
|
Is there anything else I should or need to do for this to get reviewed and merged? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds support for Prometheus metrics by adding the prometheus-cpp library, and enabling the Prometheus Luanti build flag. Build steps were adapted from the steps outlined on the official wiki.
Benefits of this PR and context:
Some users may want the ability to gather server metrics beyond CPU/memory. For instance, creating Grafana dashboards with Luanti-specific data.
How Has This Been Tested?
This has been tested by building the images and running them with a backup of an existing world and database.
Source / References:
https://wiki.minetest.net/Server_Metrics_using_Prometheus
https://github.com/jupp0r/prometheus-cpp