Fix fel-remotefunc-compiler execution on newer Ruby versions #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File.exists got removed from Ruby, File.exist should be used instead.
iscle
force-pushed
the
remotefunc-compiler-fix
branch
from
965fa94
to
984e81f
Compare
Yes! The "exist" method has always existed in Ruby, so there shouldn't be any issues :) Here's the link to the documentation of the oldest available Ruby version, with the method already present: https://ruby-doc.org/core-1.8.6/File.html#method-c-exist-3F |
|
Yes, can confirm that it works here, and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was using a deprecated (now deleted) function to check file existence.