create ip holder per cluster + tests, update docs #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosskirkpat
force-pushed
the
lke5823-ip-holder-per-cluster
branch
from
2d6c13c
to
069977a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #246 +/- ##
==========================================
+ Coverage 56.08% 56.63% +0.54%
==========================================
Files 12 12
Lines 2350 2412 +62
==========================================
+ Hits 1318 1366 +48
- Misses 881 892 +11
- Partials 151 154 +3 ☔ View full report in Codecov by Sentry. |
rahulait
reviewed
Nov 18, 2024
rahulait
reviewed
Nov 18, 2024
rahulait
reviewed
Nov 19, 2024
dthorsen
reviewed
Nov 20, 2024
|
I was able to perform e2e validation of this CCM PR for a LKE Cluster
CCM successfully shared IPs for the four test nginx LB services that I created (ccm logs w/ v5 verbosity below). # ccm args
- args:
- --v=5
- --secure-port=10253
- --webhook-secure-port=0
- --kubeconfig=xxxxxx
- --enable-route-controller=true
- --vpc-name=ross-ccm-pr246-e2e
- --configure-cloud-routes=true
- --cluster-cidr=10.248.0.0/14
- --load-balancer-type=cilium-bgp
- --ip-holder-suffix=ross-ccm-pr246-e2e
- --leader-elect=true
- --leader-elect-resource-lock=leases% KUBECONFIG=/Users/rkirkpat/.kube/clusters/ross-ccm-pr246-e2e.yaml k get svc -A -o wide
NAMESPACE NAME TYPE CLUSTER-IP EXTERNAL-IP PORT(S) AGE SELECTOR
default kubernetes ClusterIP 10.252.0.1 <none> 443/TCP 4h47m <none>
kube-system kube-dns ClusterIP 10.252.0.10 <none> 53/UDP,53/TCP,9153/TCP 4h47m k8s-app=kube-dns
test nginx LoadBalancer 10.252.11.57 172.234.194.145 80:31537/TCP 4h42m app=nginx
test1 nginx1 LoadBalancer 10.253.150.119 172.232.10.99 80:30448/TCP 17s app=nginx1
test2 nginx2 LoadBalancer 10.252.192.57 172.232.10.193 80:30400/TCP 17s app=nginx2
test3 nginx3 LoadBalancer 10.253.106.41 172.234.212.223 80:31243/TCP 17s app=nginx3% linode-cli linodes ips-list 67381594
┌─────────────────┬──────┬────────┬──────────────────────────────────────────┬────────┬───────────┐
│ address │ type │ public │ rdns │ region │ linode_id │
├─────────────────┼──────┼────────┼──────────────────────────────────────────┼────────┼───────────┤
│ 172.232.10.99 │ ipv4 │ True │ 172-232-10-99.ip.linodeusercontent.com │ us-ord │ 67381594 │
├─────────────────┼──────┼────────┼──────────────────────────────────────────┼────────┼───────────┤
│ 172.232.10.193 │ ipv4 │ True │ 172-232-10-193.ip.linodeusercontent.com │ us-ord │ 67381594 │
├─────────────────┼──────┼────────┼──────────────────────────────────────────┼────────┼───────────┤
│ 172.234.194.144 │ ipv4 │ True │ 172-234-194-144.ip.linodeusercontent.com │ us-ord │ 67381594 │
├─────────────────┼──────┼────────┼──────────────────────────────────────────┼────────┼───────────┤
│ 172.234.194.145 │ ipv4 │ True │ 172-234-194-145.ip.linodeusercontent.com │ us-ord │ 67381594 │
├─────────────────┼──────┼────────┼──────────────────────────────────────────┼────────┼───────────┤
│ 172.234.212.223 │ ipv4 │ True │ 172-234-212-223.ip.linodeusercontent.com │ us-ord │ 67381594 │
└─────────────────┴──────┴────────┴──────────────────────────────────────────┴────────┴───────────┘ |
Signed-off-by: Ross Kirkpatrick <[email protected]>
rosskirkpat
force-pushed
the
lke5823-ip-holder-per-cluster
branch
from
9facb9c
to
b14d4a1
Compare
|
Validation details for latest changes where ccm exits during cloud provider initialization if the |
AshleyDumaine
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General:
Pull Request Guidelines: