Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] : fix expired cert for e2e tests #245

Merged
merged 1 commit into from
Nov 15, 2024
Merged

[fix] : fix expired cert for e2e tests #245

merged 1 commit into from
Nov 15, 2024

Conversation

rahulait
Copy link
Collaborator

General:

  • Have you removed all sensitive information, including but not limited to access keys and passwords?
  • Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Existing server certificate used in tests expired in october 2024. This PR generates a new cert using the existing key and this certificate is valid for 3 years from now. Steps used to generate the new cert:

openssl req -new -key server.key -out server.csr -subj "/C=US/ST=PA/L=Philadelphia/O=Linode LLC/OU=Linode Test/CN=linode.test"
openssl x509 -req -extfile <(printf "subjectAltName=DNS:linode.test,DNS:www.linode.test") -in server.csr -days 1095 -CA ca.crt -CAkey ca.key -CAcreateserial -out server.crt

Test run after the fix:

[AfterSuite] PASSED [0.024 seconds]
------------------------------

Ran 22 of 23 Specs in 479.251 seconds
SUCCESS! -- 22 Passed | 0 Failed | 0 Pending | 1 Skipped
PASS

Ginkgo ran 1 suite in 8m1.65842278s
Test Suite Passed

Pull Request Guidelines:

  1. Does your submission pass tests?
  2. Have you added tests?
  3. Are you addressing a single feature in this PR?
  4. Are your commits atomic, addressing one change per commit?
  5. Are you following the conventions of the language?
  6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. Have you explained your rationale for why this feature is needed?
  8. Have you linked your PR to an open issue

@rahulait rahulait added the bugfix for any bug fixes in the changelog. label Nov 15, 2024
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.06%. Comparing base (f67f48b) to head (198de5b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #245   +/-   ##
=======================================
  Coverage   56.06%   56.06%           
=======================================
  Files          12       12           
  Lines        2349     2349           
=======================================
  Hits         1317     1317           
  Misses        881      881           
  Partials      151      151           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rahulait rahulait merged commit 9212805 into main Nov 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix for any bug fixes in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants