manage routes for instances in multiple vpcs in a single region #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #241 +/- ##
==========================================
+ Coverage 55.33% 56.06% +0.73%
==========================================
Files 12 12
Lines 2324 2349 +25
==========================================
+ Hits 1286 1317 +31
+ Misses 887 881 -6
Partials 151 151 ☔ View full report in Codecov by Sentry. |
rahulait
force-pushed
the
route-controller-multiple-vpcs
branch
2 times, most recently
from
76e0fc9
to
c04ffe9
Compare
rahulait
force-pushed
the
route-controller-multiple-vpcs
branch
from
3e62890
to
913f2b6
Compare
rahulait
commented
Nov 12, 2024
rahulait
force-pushed
the
route-controller-multiple-vpcs
branch
from
0637f31
to
f5c45fc
Compare
rahulait
force-pushed
the
route-controller-multiple-vpcs
branch
from
f5c45fc
to
f95b9bd
Compare
| Mu.Lock() | ||
| defer Mu.Unlock() | ||
|
|
||
| // check if map contains vpc id for given label | ||
| if vpcid, ok := vpcIDs[vpcName]; ok { | ||
| return vpcid, nil | ||
| } | ||
| vpcs, err := client.ListVPCs(context.TODO(), &linodego.ListOptions{}) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General:
This PR enables route-controller to manage instances running in multiple vpcs. All these instances should still be part of a single k8s cluster where the CCM is running.
This change introduces a new flag
vpc-nameswhich is a comma separated list of vpc names which will be managed by the CCM's route-controller. Old flagvpc-nameis now deprecated and will be removed in future releases.To test changes:
Changes in this branch are present in helm chart here: https://github.com/rahulait/linode-cloud-controller-manager/releases/tag/helm-v0.4.16
If one wants to test these changes, simply use helm repo https://rahulait.github.io/linode-cloud-controller-manager/ with version v0.4.16 to test the changes before we merge this branch to main.
Pull Request Guidelines: