Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make volume and volume mounts configurable through helm #238

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

eljohnson92
Copy link
Contributor

General:

  • Have you removed all sensitive information, including but not limited to access keys and passwords?
  • Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

  1. Does your submission pass tests?
  2. Have you added tests?
  3. Are you addressing a single feature in this PR?
  4. Are your commits atomic, addressing one change per commit?
  5. Are you following the conventions of the language?
  6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. Have you explained your rationale for why this feature is needed?
  8. Have you linked your PR to an open issue

Comment on lines 57 to 59
{{- if .Values.volumeMounts}}
{{- toYaml .Values.volumeMounts | nindent 12 }}
{{- end}}
Copy link
Member

@AshleyDumaine AshleyDumaine Oct 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bit of a nit but could also do:

            {{- with .Values.volumeMounts }}
            {{- toYaml . | nindent 12 }}
            {{- end }}

same below

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.30%. Comparing base (708ee98) to head (f66c3d4).
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #238      +/-   ##
==========================================
- Coverage   55.34%   55.30%   -0.04%     
==========================================
  Files          12       12              
  Lines        1881     2318     +437     
==========================================
+ Hits         1041     1282     +241     
- Misses        696      886     +190     
- Partials      144      150       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eljohnson92 eljohnson92 merged commit f4fdb50 into main Oct 21, 2024
7 of 8 checks passed
@eljohnson92 eljohnson92 deleted the configure_volumes branch October 21, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants