Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] getExistingSharedIPs should get Public IPs from the holder #232

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

dthorsen
Copy link
Contributor

General:

  • Have you removed all sensitive information, including but not limited to access keys and passwords?
  • Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

  1. Does your submission pass tests?
  2. Have you added tests?
  3. Are you addressing a single feature in this PR?
  4. Are your commits atomic, addressing one change per commit?
  5. Are you following the conventions of the language?
  6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. Have you explained your rationale for why this feature is needed?
  8. Have you linked your PR to an open issue

Description

Calls to getExistingSharedIPs should return Public IPs instead of Shared IPs, because the IPs on the holder nanode are not returned under the Shared IP's section of the API response.

fixes #231

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.29%. Comparing base (708ee98) to head (0568585).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #232      +/-   ##
==========================================
+ Coverage   55.34%   56.29%   +0.95%     
==========================================
  Files          12       12              
  Lines        1881     1881              
==========================================
+ Hits         1041     1059      +18     
+ Misses        696      672      -24     
- Partials      144      150       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AshleyDumaine
Copy link
Member

@dthorsen dthorsen merged commit 42e3341 into linode:main Oct 1, 2024
5 checks passed
@dthorsen dthorsen deleted the fix-getExistingSharedIPs branch October 1, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Nodes added following initial LoadBalancer creation missing Shared IP with Cilium BGP LoadBalancing
3 participants