Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use a custom http.Transport due to Resty incompatibility #227

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

okokes-akamai
Copy link
Contributor

@okokes-akamai okokes-akamai commented Aug 15, 2024

We're hitting the same issue as here: linode/cluster-api-provider-linode#436

When we use a custom CA, it doesn't get used.

Given that we construct an http.Transport that is of a different concrete type than http.Transport (it just needs to be a RoundTripper), resty fails and defaults to an empty client, discarding our CA.

General:

  • Have you removed all sensitive information, including but not limited to access keys and passwords?
  • Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

  1. Does your submission pass tests?
  2. Have you added tests?
  3. Are you addressing a single feature in this PR?
  4. Are your commits atomic, addressing one change per commit?
  5. Are you following the conventions of the language?
  6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. Have you explained your rationale for why this feature is needed?
  8. Have you linked your PR to an open issue

We're hitting the same issue as here: linode/cluster-api-provider-linode#436

We use a custom CA and it doesn't get used.

Given that we construct an http.Transport that is of a different
concrete type than http.Transport (it just needs to be a RoundTripper),
resty fails and defaults to an empty client, discarding our CA.
@okokes-akamai okokes-akamai marked this pull request as ready for review August 15, 2024 07:23
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.52%. Comparing base (f2b7e2a) to head (1fccf33).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #227      +/-   ##
==========================================
- Coverage   55.64%   55.52%   -0.12%     
==========================================
  Files          12       12              
  Lines        1887     1882       -5     
==========================================
- Hits         1050     1045       -5     
  Misses        694      694              
  Partials      143      143              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@rahulait rahulait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@okokes-akamai okokes-akamai merged commit 80ccbba into linode:main Aug 15, 2024
4 of 5 checks passed
@okokes-akamai okokes-akamai deleted the stop_oauth2_usage branch August 15, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants