Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support high performance ingress with no label selector #224

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

bcm820
Copy link
Contributor

@bcm820 bcm820 commented Aug 8, 2024

This change enables shared IP loadbalancing across all nodes whenever no bgpNodeSelector is specified; i.e. by default.

General:

  • Have you removed all sensitive information, including but not limited to access keys and passwords?
  • Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

  1. Does your submission pass tests?
  2. Have you added tests?
  3. Are you addressing a single feature in this PR?
  4. Are your commits atomic, addressing one change per commit?
  5. Are you following the conventions of the language?
  6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. Have you explained your rationale for why this feature is needed?
  8. Have you linked your PR to an open issue

Copy link

codecov bot commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 65.62500% with 11 lines in your changes missing coverage. Please review.

Project coverage is 56.05%. Comparing base (0c600bb) to head (b00cd63).

Files Patch % Lines
cloud/linode/cilium_loadbalancers.go 65.62% 8 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #224      +/-   ##
==========================================
+ Coverage   55.69%   56.05%   +0.36%     
==========================================
  Files          12       12              
  Lines        1860     1873      +13     
==========================================
+ Hits         1036     1050      +14     
  Misses        680      680              
+ Partials      144      143       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@rahulait rahulait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haven't deployed, but otherwise the changes look good to me

@bcm820 bcm820 merged commit af045d1 into main Aug 12, 2024
5 checks passed
@bcm820 bcm820 deleted the default-all-nodes-lb branch August 12, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants