Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include ipv6 address for node external IPs #217

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Conversation

AshleyDumaine
Copy link
Member

This updates Nodes to also have their ipv6 address set for their external IPs to support dual-stack / ipv6-enabled clusters.

General:

  • Have you removed all sensitive information, including but not limited to access keys and passwords?
  • Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

  1. Does your submission pass tests?
  2. Have you added tests?
  3. Are you addressing a single feature in this PR?
  4. Are your commits atomic, addressing one change per commit?
  5. Are you following the conventions of the language?
  6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. Have you explained your rationale for why this feature is needed?
  8. Have you linked your PR to an open issue

@AshleyDumaine AshleyDumaine marked this pull request as draft June 17, 2024 19:54
@AshleyDumaine AshleyDumaine marked this pull request as ready for review June 17, 2024 21:09
Copy link
Collaborator

@rahulait rahulait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

With vpcless installs:

KUBECONFIG=./kubeadm8.yaml k get node kubeadm8-control-plane-96m6p -o yaml | yq .status.addresses
- address: kubeadm8-control-plane-96m6p
  type: Hostname
- address: 172.233.218.251
  type: ExternalIP
- address: 2600:3c06::f03c:94ff:fe1e:39c7
  type: ExternalIP
- address: 192.168.146.232
  type: InternalIP

With VPC installs:

KUBECONFIG=./kubeadm1.yaml k get node kubeadm1-control-plane-vt8hf -o yaml | yq .status.addresses
- address: kubeadm1-control-plane-vt8hf
  type: Hostname
- address: 10.0.0.2
  type: InternalIP
- address: 192.168.150.247
  type: InternalIP
- address: 172.234.216.122
  type: ExternalIP
- address: 2600:3c06::f03c:94ff:fe1e:cf11
  type: ExternalIP

@AshleyDumaine AshleyDumaine merged commit 4cda99a into main Jun 20, 2024
3 checks passed
@AshleyDumaine AshleyDumaine deleted the dual-stack-support branch June 20, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants