Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use tag ref for helm-release so the release workflow can start it #216

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

rl0nergan
Copy link
Contributor

General:

  • Have you removed all sensitive information, including but not limited to access keys and passwords?
  • Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

  1. Does your submission pass tests?
  2. Have you added tests?
  3. Are you addressing a single feature in this PR?
  4. Are your commits atomic, addressing one change per commit?
  5. Are you following the conventions of the language?
  6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. Have you explained your rationale for why this feature is needed?
  8. Have you linked your PR to an open issue

#179 should have restricted helm-releases to be kicked off via the release workflow, but when the happens github.ref gets set to the git ref of the newly created tag and is no longer main. This resulted in the job getting skipped and only the test running on releases.

This PR switches the conditional to look for a github.ref that starts with /ref/tags/ instead

@nesv nesv merged commit 71e7855 into linode:main Jun 7, 2024
3 checks passed
@rl0nergan rl0nergan deleted the fix/helm-release branch June 7, 2024 13:49
@nesv nesv added the ci Integration continuously intensifies label Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Integration continuously intensifies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants