Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace helper #170

Merged
merged 2 commits into from
Jan 19, 2024
Merged

Replace helper #170

merged 2 commits into from
Jan 19, 2024

Conversation

tchinmai7
Copy link
Contributor

Remove a helper method and replace it with native kube functions.

General:

  • Have you removed all sensitive information, including but not limited to access keys and passwords?
  • Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

  1. Does your submission pass tests?
  2. Have you added tests?
  3. Are you addressing a single feature in this PR?
  4. Are your commits atomic, addressing one change per commit?
  5. Are you following the conventions of the language?
  6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. Have you explained your rationale for why this feature is needed?
  8. Have you linked your PR to an open issue

@luthermonson
Copy link
Contributor

Ran 19 of 20 Specs in 354.574 seconds
SUCCESS! -- 19 Passed | 0 Failed | 0 Pending | 1 Skipped
PASS

@tchinmai7 tchinmai7 merged commit 2878e34 into main Jan 19, 2024
4 checks passed
@tchinmai7 tchinmai7 deleted the feat/refactor-annotations branch January 23, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants