always return lbnotfound from getNodeBalancerForService #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you reflect this change in tests? Fix the failing one and perhaps add some new ones. |
luthermonson
force-pushed
the
check-move
branch
from
fa418e0
to
9812dbc
Compare
tests added, fail in main but pass in my branch |
luthermonson
force-pushed
the
check-move
branch
2 times, most recently
from
2f520b3
to
aaab0ca
Compare
luthermonson
force-pushed
the
check-move
branch
from
aaab0ca
to
0714d4b
Compare
okokes-akamai
approved these changes
Jan 23, 2024
tchinmai7
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found an edge case where I had deleted a nodebalancer but it was set on a service and wouldn't clear the finalizer and never saw the short-circuit log from here: https://github.com/linode/linode-cloud-controller-manager/blob/main/cloud/linode/loadbalancers.go#L413
the lbnotfound type check was rewriting to a new error and never returning so moving the onus on checking lbnotfound to the create path so a second load balancer is not created and the skip now works.