upgrade to v2 klog everywhere #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
luthermonson
commented
Jan 3, 2024
•
luthermonson
commented
- drops the v1 klog + usage in main.go
- upgrades to v0.23.0 to get the logr upgrade fixed in component-base
luthermonson
force-pushed
the
remove-klog-v1
branch
3 times, most recently
from
e6a8508
to
4cdd95b
Compare
luthermonson
force-pushed
the
remove-klog-v1
branch
from
4cdd95b
to
93fb1cf
Compare
tchinmai7
approved these changes
Jan 5, 2024
luthermonson
force-pushed
the
remove-klog-v1
branch
from
d8b3e07
to
d4a40ab
Compare
|
@schinmai-akamai go mod fixed and merging now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.