Attach firewall when creating nodebalancer

[rammanoj]

Fixes #142

Changes:

• Upgrade Linodego dependency to the latest available version v1.25.0 and fix the existing unit-test failures due to the changes.
• Add support to attach firewall to node balancer when creating a node balancer.
  • Add corresponding unit-tests:
    • Create NodeBalancer without a firewall
    • Create NodeBalancer with an invalid firewall ID
    • Create NodeBalaner with a valid firewall ID

General:

• Have you removed all sensitive information, including but not limited to access keys and passwords?
• Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

1. Does your submission pass tests?
2. Have you added tests?
3. Are you addressing a single feature in this PR?
4. Are your commits atomic, addressing one change per commit?
5. Are you following the conventions of the language?
6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
7. Have you explained your rationale for why this feature is needed?
8. Have you linked your PR to an open issue

[tchinmai7]

I think you have to run go mod tidy to fix the lint issues

[okokes-akamai]

I have one last comment about testing, but otherwise it looks good.

The one big problem with this is that it only supports creation, which is just... insufficient. I understand we're limited by the Linode API, but given this, we should really make sure this is super alpha, not something that should be used beyond some testing. (cc @schinmai-akamai)

[okokes-akamai]

Turns out it should be possible to remove firewalls from nodebalancer by using DeleteFirewallDevice (thanks, Tarun, for pointing this out). So if we're going the creation route, we should also incorporate this (if possible).

[rammanoj]

Turns out it should be possible to remove firewalls from nodebalancer by using DeleteFirewallDevice (thanks, Tarun, for pointing this out). So if we're going the creation route, we should also incorporate this (if possible).

Yup, the devices on the firewalls could be updated or deleted. I will be incorporating these changes as well!

[rammanoj]

Turns out it should be possible to remove firewalls from nodebalancer by using DeleteFirewallDevice (thanks, Tarun, for pointing this out). So if we're going the creation route, we should also incorporate this (if possible).

The linodego doesn't yet have the ability to list firewalls of a nodebalancer. The update feature can be added as soon as the ability has been added (https://jira.linode.com/browse/TPT-2535)

[luthermonson]

Turns out it should be possible to remove firewalls from nodebalancer by using DeleteFirewallDevice (thanks, Tarun, for pointing this out). So if we're going the creation route, we should also incorporate this (if possible).

The linodego doesn't yet have the ability to list firewalls of a nodebalancer. The update feature can be added as soon as the ability has been added (https://jira.linode.com/browse/TPT-2535)

#146

[okokes-akamai]

One last bit of comment regarding the refactored tests. Feel free to merge once you incorporate the small changes I suggested.