Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support adding tags to nodebalancers #138

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Conversation

tchinmai7
Copy link
Contributor

General:

  • Have you removed all sensitive information, including but not limited to access keys and passwords?
  • Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Support adding tags to a nodebalancer - supply a comma-separated string in an annotation to a service of type LoadBalancer to automatically add tags to the created node-balancer resource. Fixes #137

Pull Request Guidelines:

  1. Does your submission pass tests?
  2. Have you added tests?
  3. Are you addressing a single feature in this PR?
  4. Are your commits atomic, addressing one change per commit?
  5. Are you following the conventions of the language?
  6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. Have you explained your rationale for why this feature is needed?
  8. Have you linked your PR to an open issue

@okokes-akamai
Copy link
Contributor

This only covers the creation path, what about the [uU]pdateNodeBalancer flow - I'd think we want to support that as well? I.e. annotation gets updated -> NB gets their tags updated as well.

@tchinmai7
Copy link
Contributor Author

This only covers the creation path, what about the [uU]pdateNodeBalancer flow - I'd think we want to support that as well? I.e. annotation gets updated -> NB gets their tags updated as well.

good catch - will update

@tchinmai7 tchinmai7 merged commit 1e53829 into linode:master Nov 8, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support tagging resources
3 participants