Filter NodeBalancers when we know their ipv4 #126
Conversation
|
I see the LinodeGo update PR: #118 |
|
The original plan was to do these two things together (and PR 118 had these two changes baked in), but then we found out the v1 update will cause an issue wrt env variables - we can't use our current So in order to expedite this server-side filter, we decided to split the work in two. |
| // return nil, err | ||
| // } | ||
| filter := fmt.Sprintf(`{"ipv4": "%v"}`, ipv4) | ||
| lbs, err := l.client.ListNodeBalancers(ctx, &linodego.ListOptions{Filter: filter}) | ||
| if err != nil { | ||
| return nil, err | ||
| } |
There was a problem hiding this comment.
It seems the loop below this may no longer be needed if we are getting the exact ip. Or it could be adjusted to be cleaner. Although leaving it how it is I don't think will harm anything.
There was a problem hiding this comment.
Good point. Did you have something like this in mind?
if len(lbs) == 0 {
return nil, lbNotFoundError{serviceNn: getServiceNn(service)}
}
klog.V(2).Infof("found NodeBalancer (%d) for service (%s) via IPv4 (%s)", lbs[0].ID, getServiceNn(service), ipv4)
return &lbs[0], nil
General:
Pull Request Guidelines: