[feat] - Support for firewalling control plane #169
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
AshleyDumaine
force-pushed
the
control-plane-fw
branch
from
02b4a6f
to
5457953
Compare
AshleyDumaine
force-pushed
the
control-plane-fw
branch
from
4e4f307
to
a6c083f
Compare
AshleyDumaine
added
feature
|
I've opened up an issue on the CCM repo to get CCM-managed firewalls added so we can remove a large chunk of this logic since we already need the CCM as part of workload clusters. CCM-managed Firewalls are a new feature on the CCM for NBs and it shouldn't be too much of a lift to extend support for Linodes too. |
|
Closing for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This adds a new LinodeFirewall CRD (w/o a reconciler for now) for Cloud Firewall support. If a LinodeCluster has a Control Plane Firewall ID set, the control plane node IPs and the control plane endpoint (e.g. NB) IP will be added to it.
The LinodeCluster reconciler doesn't create LinodeFirewall k8s resources, instead it creates/updates/deletes a Cloud Firewall for the control plane based on the ControlPlaneFirewallSpec.
We might later want to add a controller to reconcile LinodeFirewall resources so additional Cloud Firewalls can be created by CAPL that can apply to Linodes and/or NBs (e.g. https://github.com/linode/cluster-api-provider-linode/tree/firewall-controller)
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs: