[feat] add HelmChartProxies for linode-ccm and linode-csi-driver, install ccm and cilium for default template #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshleyDumaine
force-pushed
the
ccm-and-csi
branch
from
eedf0e9
to
bdc4d2a
Compare
AshleyDumaine
force-pushed
the
ccm-and-csi
branch
from
e8737f9
to
29e17e6
Compare
AshleyDumaine
force-pushed
the
ccm-and-csi
branch
from
29e17e6
to
3069d83
Compare
eljohnson92
reviewed
Feb 14, 2024
eljohnson92
reviewed
Feb 14, 2024
AshleyDumaine
force-pushed
the
ccm-and-csi
branch
from
5f31463
to
6d20e3a
Compare
eljohnson92
reviewed
Feb 16, 2024
eljohnson92
reviewed
Feb 16, 2024
| apiTokenRef: "apiToken" | ||
| regionRef: "region" | ||
| image: | ||
| tag: v0.3.24 |
There was a problem hiding this comment.
can we move this version into the version field of the chart? each version should set the image tag correctly
eljohnson92
reviewed
Feb 16, 2024
eljohnson92
reviewed
Feb 16, 2024
eljohnson92
approved these changes
Feb 16, 2024
AshleyDumaine
changed the title
amold1
pushed a commit
that referenced
this pull request
May 17, 2024
…tall ccm and cilium for default template (#116) * add HelmChartProxies for linode-ccm and linode-csi-driver * install CCM and cilium by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it so CAAPH can install the linode-csi and linode-ccm charts and installs cilium and the linode-ccm by default since they are critical components for the cluster to work properly. CSI can still be installed via the addon template.
The linode-CCM is a necessary component for provisioned k8s 1.29 clusters to correctly set the internal and external IPs.
Closes #101
Closes #100
Depends on linode/linode-cloud-controller-manager#177