feat(exchange-analytics): Binance Bybit Ftx #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #4859: Create and Deploy Integration for Rage Trade. |
vnavascues
suggested changes
Sep 23, 2022
There was a problem hiding this comment.
Excellent job
Important:
- Rebase develop
- Binance timestamp needs to be floored
- Align it with
kyc-adapter, e.g. config file (and its tests), payload types, etc. asset: IMHO we should allow to requestfrom(base) andto(quote). We are limiting ourselves lots by hard coding them. The 3 APIs make easy to request all the supported markets. What I suggest for the Rage Trade job is having the 3 quote assets hard coded in the TOML spec.
Also some food for thought:
- Endpoint name:
funding-ratesorfutures? I'm aware Bybit APi is very specific. Just wondering how much are we limiting our response by not adopting "futures".
| description: 'The name of the asset.', | ||
| required: true, | ||
| type: 'string', | ||
| options: [Asset.ETH, Asset.BTC], |
There was a problem hiding this comment.
We need to chat about this, I think we are limiting the adapter by do not allowing <base/from><quote/to>. These APIs support lots of tickers for perpetual markets and we are hard coding the quote assets.
packages/exchange-analytics/test/integration/funding-rates/get.ts
Outdated
Show resolved
Hide resolved
1marcghannam
force-pushed
the
feature/sc-4859/exchange-analytics
branch
from
e1f248d
to
70ef968
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.