Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the Thrift compiler binaries for macOS on aarch64 (M1) #115

Merged
merged 1 commit into from
Feb 25, 2022

Conversation

trustin
Copy link
Member

@trustin trustin commented Feb 24, 2022

  • Added the Thrift compiler binaries for all supported versions
  • Added the Thrift compiler binary for 0.16 (macOS on aarch64 only)
  • Ran the strip command on all existing macOS binaries

- Added the Thrift compiler binaries for all supported versions
- Added the Thrift compiler binary for 0.16 (macOS on aarch64 only)
Copy link
Member

@minwoox minwoox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @trustin!

Copy link
Contributor

@ikhoon ikhoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@trustin trustin merged commit a0f3c3b into line:master Feb 25, 2022
@trustin trustin deleted the aarch64_thrift_binaries branch February 25, 2022 00:51
@0x1306e6d
Copy link

0x1306e6d commented Feb 25, 2022

Would this PR close #82?
This PR is dedicated on macOS. Sorry 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants