Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Change phpunit workflow to allow disabling specific test environments when incompatibilities are encountered. #1437

Open
wants to merge 2 commits into
base: 3.x
Choose a base branch
from

Conversation

robfrawley
Copy link
Collaborator

Q A
Branch? 3.x
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? yes/no
Fixed tickets #1436 (comment)
License MIT
Doc n/a

I am testing some different changes to resolve the above-titled issue; no single solution to the problem has been determined appropriate for this project yet. As such, do not merge!
__

@robfrawley robfrawley self-assigned this Dec 1, 2021
@robfrawley robfrawley added Attn: Minor This issue or PR is a minor problem or minor change. State: Confirmed This item has been confirmed by maintainers as legitimate. Type: Configuration This item pertains to configuration of this project. labels Dec 1, 2021
@robfrawley
Copy link
Collaborator Author

Looks like we need to wait on php-coveralls/php-coveralls#328 for a resolution to our failing workflows when running with any Symfony 6.x release.

@dbu: For the time being, do you want me to update the workflow matrix to disable coveralls reporting on incompatible environments? If so, we could do that in such a way as to quickly be able to enable/disable certain environments easily, something that will likely be useful again in the future when a different incompatibility pops up...

@robfrawley robfrawley changed the title [WIP] Lock php-coveralls version to resolve Symfony6/PHP8 compatibility issue in phpunit GitHub workflow tests [WIP] Change phpunit workflow to allow disabling specific test environments when incompatibilities are encountered. Dec 1, 2021
@dbu
Copy link
Member

dbu commented Dec 2, 2021

thanks for looking into this!

how about disabling the coveralls step completely when php version is 8, until coveralls fixes their signature to be compatible with symfony? or even mark just 1 build in the matrix to actually do the coveralls things. i don't think we need coverage for each case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Attn: Minor This issue or PR is a minor problem or minor change. State: Confirmed This item has been confirmed by maintainers as legitimate. Type: Configuration This item pertains to configuration of this project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants