[RFC] removed webpath set to null on unset resolver #1216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this PR! I would definitely merge this bugfix and release in 3.0 as it is indeed a slight BC break. I'd be super happy if you go ahead and fix the related tests. |
|
sounds great. will have a look at the tests this week |
dbu
added
Level: Bug 🐞
|
i don't think we can simply remove the default resolver. maybe we could add it in the extension class instead of the configuration class to avoid the problem when merging configurations? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alredy commented in #1132 (comment) but i thought a PR is more visible to get comments.
haven't tried to run or fix tests because first it makes sense to know if you would merge this.