Refactor: Use nullable type hints for optional dependencies and param… #1261
+6
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eters Updated constructors and method signatures to explicitly use nullable type hints (?Type) for optional parameters and dependencies. This improves code clarity and ensures alignment with modern PHP type hinting practices. - Updated JWTAuthenticator to use ?TranslatorInterface and ?AuthenticationException where applicable. - Modified AuthenticationFailureHandler to use ?TranslatorInterface in the constructor. - Adjusted LcobucciJWSProvider to use ?Clock in the constructor for better nullability support. - Updated JWTManager to use ?PayloadEnrichmentInterface for the optional payload enrichment dependency. These changes improve type safety, readability, and consistency across the codebase.
|
There's already a PR on this topic : #1238 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Deprecation Notices in LexikJWTAuthenticationBundle
Summary
This pull request addresses multiple deprecation notices that occur when using the LexikJWTAuthenticationBundle with PHP 8.4. The fixes involve explicitly marking nullable parameters in constructors and methods to comply with PHP 8.4 requirements.
Fixed Issues
JWTAuthenticator::__construct
Implicitly marking parameter
$translatoras nullable is deprecated. The parameter is now explicitly marked as?TranslatorInterface.JWTAuthenticator::start
Implicitly marking parameter
$authExceptionas nullable is deprecated. The parameter is now explicitly marked as?AuthenticationException.JWTManager::__construct
Implicitly marking parameter
$payloadEnrichmentas nullable is deprecated. The parameter is now explicitly marked as?PayloadEnrichmentInterface.LcobucciJWSProvider::__construct
Implicitly marking parameter
$clockas nullable is deprecated. The parameter is now explicitly marked as?ClockInterface.AuthenticationFailureHandler::__construct
Implicitly marking parameter
$translatoras nullable is deprecated. The parameter is now explicitly marked as?TranslatorInterface.Changes Made
Environment
Additional Context
These changes aim to ensure smooth operation in PHP 8.4 environments by addressing all known deprecation warnings related to nullable parameters.