Fix default values in WebToken services when encryption disabled #1225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeuralClone
force-pushed
the
bugfix/incorrect-webtoken-default-args
branch
2 times, most recently
from
38999c3
to
e5839cd
Compare
NeuralClone
force-pushed
the
bugfix/incorrect-webtoken-default-args
branch
from
e5839cd
to
ff16323
Compare
|
Any chance to review this? This affects fresh installations using web-token. |
|
A review for this PR would definitely be greatly appreciated. In the original issue I opened, I posted a follow-up comment with a workaround that involves adding a compiler pass to your project. Here's a direct link to it in case you missed it: It doesn't actually solve the configuration problem, of course. It also assumes that encryption will remain disabled. But it should let you use the web token services until this PR is reviewed/merged or another solution is implemented. |
chalasr
approved these changes
Oct 15, 2024
maxhelias
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the default values in the
AccessTokenBuilderandAccessTokenLoaderservices when encryption is disabled.