Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project Initialized #6

Closed
wants to merge 3 commits into from

Conversation

PrerakMathur20
Copy link

@PrerakMathur20 PrerakMathur20 commented Mar 5, 2022

Fixes #5

  • The project has been Initialized with React Typescript library.
  • Rollup has been added as a Bundler with necessary plugins.

@PrerakMathur20
Copy link
Author

Not to be confused with as a duplicate of #2


The package.json file shouldn't have any contributor's repository linked as shown:

"url": "git+https://github.com/Janvi-Thakkar/react-email.git"

"url": "https://github.com/Janvi-Thakkar/react-email/issues"

"homepage": "https://github.com/Janvi-Thakkar/react-email#readme",

Most probably these accidentally slipped in during the project's default initialization with npm.
Special attention to this issue was paid by me while I was setting up the project, which makes this PR different from the one mentioned earlier.

@agentmilindu
Copy link
Contributor

Let’s follow the commonly accepted best practices for the commit messages. Ref here

@Janvi-Thakkar
Copy link

Janvi-Thakkar commented Mar 6, 2022

@PrerakMathur20 Thank you for pointing this out. I will keep this in mind. But I believe in this case if you have suggested me to improve the PR that would be better than making new PR for the same thing as this might be conflicting for the reviewer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project not Initialized
3 participants