-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for macOS Apple Silicon #7342
base: master
Are you sure you want to change the base?
Conversation
Nice - thanks for trying this. |
8b79fdd
to
7b805e4
Compare
Todo:
|
Cool. I'm going to create my own branch of this and PR it so that CI will run. |
@jessopb If you want I can add you to my fork as a contributor so you can push any changes there |
I thikn if I push it, CI will run with the appropriate secrets? I'm not sure why it failed last time. |
Quick note for building universal app:
|
I think what I'm going to do is add a settings feature that allows people to enable prerelease autoupdates. We'll release that when we get this CSC thing ironed out for windows, then we'll do this as a prerelease that can be e2e tested. |
@jessopb any chance you could nudge somebody on the team to take a look at this lbryio/lbry-sdk#3516 ? |
Yep, done. There was mention of it this morning at meeting. |
Currently it's building x64 and arm64 electron apps. We *could* make DMGs of each and have end users select their platform.
Currently this is building x64 and arm64 electron apps.
We could make DMGs of each and have end users select their platform.
Fixes
Issue Number: #7338
What is the current behavior?
Only x64 builds for macOS
What is the new behavior?
x64 & arm64 builds for macOS
Other information
PR Checklist
Toggle...
What kind of change does this PR introduce?
Please check all that apply to this PR using "x":