Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] donot exit the snapshot on app exceptions #93

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

aabidsofi19
Copy link
Contributor

Notes for Reviewers

This PR fixes #
the pr prevents the whole snapshot from getting crashed on some uncaught internal exception ( like arising from failed api request using the old axios , in some promise )

also logs back the whole exception which might help in debugging them

  • Yes, I signed my commits.

Copy link
Contributor

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logs will be available in the workflow of the repo that runs the Snapshot, right?

Copy link

github-actions bot commented Mar 6, 2024

@leecalcote
Copy link
Contributor

leecalcote commented Mar 6, 2024

@aabidsofi19 the screenshot above is still fairly difficult to read.

@MUzairS15 and it links to a Page Not Found.

@aabidsofi19
Copy link
Contributor Author

The logs will be available in the workflow of the repo that runs the Snapshot, right?

yeah

Copy link
Contributor

@MUzairS15 MUzairS15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, was going to add similar debug logs.
The cause we discussed I think that's the whole issue, but to be sure let's see what the error is.

@MUzairS15 MUzairS15 merged commit ffed4fe into master Mar 6, 2024
2 of 5 checks passed
@MUzairS15 MUzairS15 deleted the snapshot-crash-fix branch March 6, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants