Added initial playwright configuration #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VaibhavMalik4187
force-pushed
the
playwright-configuration
branch
3 times, most recently
from
ee4a948
to
4efbf80
Compare
|
@leecalcote Let's prototype the Playwright configuration here. |
- Created the `playwright-action` directory. - Added basic playwright configuration in the playwright-action directory. - Created a new playwright workflow to run playwright tests. Signed-off-by: VaibhavMalik4187 <[email protected]>
VaibhavMalik4187
force-pushed
the
playwright-configuration
branch
from
4efbf80
to
a48947e
Compare
|
The situation is very dicey here. Tests are randomly passing and failing. In the last CI run, every single test passed in the runner. All of them failed when I ran |
leecalcote
reviewed
Sep 8, 2023
.github/workflows/playwright.yml
Outdated
| name: Playwright Tests | ||
| on: | ||
| push: | ||
| branches: [main, master] |
leecalcote
reviewed
Sep 8, 2023
| - uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: 18 | ||
| - name: Install dependencies |
There was a problem hiding this comment.
Are there no playwright github actions?
leecalcote
requested changes
Sep 8, 2023
.github/workflows/playwright.yml
Outdated
| with: | ||
| name: /playwright-action/playwright-report | ||
| path: /playwright-action/playwright-report/ | ||
| retention-days: 1 |
.github/workflows/playwright.yml
Outdated
| branches: [main, master] | ||
| jobs: | ||
| test: | ||
| timeout-minutes: 10 |
There was a problem hiding this comment.
Not necessary and will only inevitably need a bump up.
| }, | ||
|
|
||
| { | ||
| name: "firefox", |
| await page.goto("https://playground.meshery.io/extension/meshmap"); | ||
|
|
||
| // Expect a title "to contain" a substring. | ||
| await expect(page).toHaveTitle( |
There was a problem hiding this comment.
This sort of thing is too fragile.
Updated the playwright config to: - Capture the screenshot of the test. - Record a video of execution of the test. - Enabled the headless mode (i.e. playwright will open the browser while executing the tests). However, it is not useful for CI environments. - Updated the timout values for the tests, and the retention period of the reports. Added the test script in package json. Added the "Login and logout test": - It'll visit playground website. - Login using the given creds. - Click on the hamburger menu on the top-right corner. - And log out. Signed-off-by: VaibhavMalik4187 <[email protected]>
VaibhavMalik4187
force-pushed
the
playwright-configuration
branch
from
a48947e
to
bf94885
Compare
leecalcote
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
This PR fixes #