Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert cloud catalog sort menu and search field to sistent #753

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

amitamrutiya
Copy link
Contributor

Notes for Reviewers

image

Signed commits

  • Yes, I signed my commits.

@amitamrutiya
Copy link
Contributor Author

@aabidsofi19 @sudhanshutech Now this catalog search and sort is useful for the open catalog model functionality. could you please review?

@aabidsofi19
Copy link
Contributor

use theme tokens, this is not compatible with darkmode

@amitamrutiya
Copy link
Contributor Author

Done @aabidsofi19

@aabidsofi19
Copy link
Contributor

confilcts here , make it a bit more generic ( not specific to catolog )

@amitamrutiya
Copy link
Contributor Author

@aabidsofi19 There is no need to create a sort by component for the catalog we can build them from the other sistent component. For the search one we already have stylesearchbar that we are not using anywhere so i added some styles to it so it looks like a cloud one so we can use it in other places.

I hope it make sense to you.

@aabidsofi19 aabidsofi19 merged commit 935efaf into layer5io:master Oct 11, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants