-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Catalog Card and add flip effect #720
Conversation
Signed-off-by: Sudhanshu Dasgupta <[email protected]>
do not merge this now |
@sudhanshutech @SAHU-01 is this ready for merge? |
no @amitamrutiya its not ready to merge, there is some work left on the back side of card to incorporate the styles of technologies and some other minute styles |
@sudhanshutech one request could you please prioritize this and merge this so I can use those cards in the extension repo as well? I want to use this in the empty kanvas catalog modal. |
…o refactor/card
Signed-off-by: Sudhanshu Dasgupta <[email protected]>
Signed-off-by: Sudhanshu Dasgupta <[email protected]>
@amitamrutiya go for it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (!shouldFlip) {
return (
<DesignCard shouldFlip={shouldFlip} isDetailed={isDetailed} outerStyles={outerStyles}>
<DesignInnerCard shouldFlip={shouldFlip} className="innerCard">
<CardFront shouldFlip={shouldFlip} isDetailed={isDetailed}>
{children}
</CardFront>
</DesignInnerCard>
</DesignCard>
);
}
Can you also add this code? Some of the cards without flip functionality behave differently.
Additionally, your PR has a different position for the back side version, so could you please check that as well?
@amitamrutiya directly commit to this branch. Take it over. |
Sounds good @amitamrutiya 👍 |
Notes for Reviewers
This PR fixes #
Signed commits