[Components] Add sistent naming convention for our components #465
Conversation
Signed-off-by: sudhanshu dasgupta <[email protected]>
|
@nebula-aac we discussed in meet that it is good to use our own naming convention while exporting these components . Make sense to you @nebula-aac ? |
sudhanshutech
added
component/ui
kind/enhancement
They might because i think these styled component will only play major role when wrapped with sistent provider right!. |
| @@ -1,7 +1,7 @@ | |||
| import { Components, Theme } from '@mui/material'; | |||
| import { CHARCOAL, connected, darkSlateGray } from '../colors'; | |||
|
|
|||
| export const MuiCheckbox: Components<Theme>['MuiCheckbox'] = { | |||
| export const SistentCheckbox: Components<Theme>['MuiCheckbox'] = { | |||
There was a problem hiding this comment.
@sudhanshutech using sistent as prefix is redundant ( as they will be scoped under sistent ) , I would suggest use Base-<Component> for unstyled / customizable component and <Functionality-<Component> for customized and ready to use ones , @nebula-aac whats your opinion ?
There was a problem hiding this comment.
It can get a bit long-winded in trying to import the components by names if they were set like that. If this is for internal use, perhaps maybe, but when it comes to exporting, we don't want the naming convention to be too complex to where errors happen because of spellings or one component was meant for something else.
There was a problem hiding this comment.
@nebula-aac @sudhanshutech we dont need to have a complex naming convention , lets agree of something simple and stay consistent
|
@sudhanshutech @nebula-aac I would suggest using our custom convention for both private and public components |
Notes for Reviewers
This PR fixes #
For being consistent we can use the sistent naming convention instead of mui for exporting these theme based components.
Signed commits