[component] Custom Mui Data Table component #155
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sudhanshu Dasgupta <[email protected]>
sudhanshutech
commented
Oct 10, 2023
| theme?: object; | ||
| } | ||
|
|
||
| const ResponsiveDataTable: React.FC<ResponsiveDataTableProps<unknown>> = ({ |
There was a problem hiding this comment.
@nebula-aac i think unknown is not a right type, can you provide some guidance in here
sudhanshutech
changed the title
|
@nebula-aac configuring the table is making things hard. I am not able to import the data table intenaly |
|
@leecalcote @sudhanshutech I have a fix for this but I don't have enough time to review it right now. I will provide my feedback this weekend on this PR. |
|
closed as this is already merged in on a different PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
This PR fixes #119
I will provide a proper readme also in a while
Signed commits