Input Search Dark Mode Friendly #5883

THEBOSS0369 · 2024-09-15T11:31:26Z

This PR fixes #5734

Description

I have added some changes so that the input looks like more dark friendly. The changes for style has been done for Intergration Page, Home Page and Blog Page. The style is same as the style in layer5/news page. Below are the ss for the changes made.

Notes for Reviewers
This PR is same as this one #5881 . It is made because of DCO error not resolving.

Signed commits

Yes, I signed my commits.

Signed-off-by: Ashparsh Pandey <[email protected]> Signed-off-by: THEBOSS0369 <[email protected]>

Signed-off-by: l5io <[email protected]> Signed-off-by: THEBOSS0369 <[email protected]>

Signed-off-by: THEBOSS0369 <[email protected]>

l5io · 2024-09-15T11:56:58Z

🚀 Preview for commit ae8e3af at: https://66e6cb30f79a9a88c715ccb7--layer5.netlify.app

Ashparshp · 2024-09-16T03:10:33Z

@THEBOSS0369, Thank you for your contribution!
Let's discuss this during the website call on Monday at 5:30 PM IST (7:00 AM CT).

I'm adding it as an agenda item to the meeting minutes || meeting link.

vishalvivekm · 2024-09-16T11:45:31Z

src/theme/app/themeStyles.js

We wouldn't want to change theme colors @THEBOSS0369

vishalvivekm · 2024-09-16T16:05:28Z

@THEBOSS0369
Sharing the links form our discussion in websites meeting

layer5/src/sections/Company/News-grid/NewsGrid.style.js

Line 102 in b0d781f

background-color: ${props => props.theme.shadowDarkColor}!important;
https://github.com/layer5io/layer5/blob/master/CONTRIBUTING.md#things-to-keep-in-mind-1

vishalvivekm · 2024-09-16T16:08:24Z

Also, will you please remove commits not pertinent to the issue ?

THEBOSS0369 · 2024-09-16T16:13:59Z

@THEBOSS0369
Sharing the links form our discussion in websites meeting

layer5/src/sections/Company/News-grid/NewsGrid.style.js

Line 102 in b0d781f

background-color: ${props => props.theme.shadowDarkColor}!important;

https://github.com/layer5io/layer5/blob/master/CONTRIBUTING.md#things-to-keep-in-mind-1

Thanks for sharing this!! 🙂🙂

THEBOSS0369 · 2024-09-17T01:29:47Z

Also, will you please remove commits not pertinent to the issue ?

Sure! I will remove the changes from searchbox. Js and apply the changes in gridestyle. Js

vishalvivekm · 2024-09-17T03:13:57Z

Also, will you please remove commits not pertinent to the issue ?

Sure! I will remove the changes from searchbox. Js and apply the changes in gridestyle. Js

I was referring to these Commits:

src/reusecore/Search/searchbox.style.js

THEBOSS0369 · 2024-09-17T10:22:25Z

Also, will you please remove commits not pertinent to the issue ?

Sure! I will remove the changes from searchbox. Js and apply the changes in gridestyle. Js

I was referring to these Commits:

Ohhhh, i get it now! I didn't commited those changes but can you tell me how do i remove those commits like do i have to revert back or any other way.

THEBOSS0369 · 2024-09-17T10:51:18Z

@vishalvivekm Can you confirm that i have to do Delete File right??

Signed-off-by: THEBOSS0369 <[email protected]>

THEBOSS0369 · 2024-09-20T05:04:08Z

Hey @vishalvivekm ! Please review the changes i made. Also, now the style is similar as the style of searchbox in /news page.

l5io · 2024-09-20T05:17:50Z

🚀 Preview for commit b263459 at: https://66ed04ee857b09e66702c1f3--layer5.netlify.app

vishalvivekm · 2024-09-22T17:07:07Z

@THEBOSS0369 why are we still modifying the themes hex codes?

vishalvivekm · 2024-09-22T17:09:10Z

@THEBOSS0369 why are we still modifying the themes hex codes?

Please review the feedback: https://m.youtube.com/watch?v=7ln7cWOHOKo&t=570s

Signed-off-by: THEBOSS0369 <[email protected]>

THEBOSS0369 · 2024-09-25T07:34:55Z

Hey @vishalvivekm ! Apologies for late reply.
I got confused and wasn't able to figure out how to do it. Now I have sorted everything, I have added the style for Searchbox in Required Page's ...grid.style.js file and removed the changes from the Themestyles.js and searchbox.style.js .

Note the Changes you will see in Searchhox.style.js are the changes which I copied from the official searchbox.style.js to revert back to the original changes from the main branch.

Thanks

l5io · 2024-09-26T19:58:19Z

🚀 Preview for commit df81b5e at: https://66f5bc40a708be4127521040--layer5.netlify.app

sudhanshutech · 2024-10-09T10:48:36Z

@THEBOSS0369 any updates?

THEBOSS0369 · 2024-10-09T10:51:10Z

@THEBOSS0369 any updates?

Hey @sudhanshutech ! This PR is completed and ready to merge. I had exams which ended today that's why i wasn't able. To join the meeting.
Thanks

Signed-off-by: Anuj Kumar Sharma <[email protected]>

THEBOSS0369 · 2024-10-17T07:06:37Z

@sudhanshutech @vishalvivekm ! I have removed the code from the required searchbox's respective files and add it to the global styles so that in future we don't have to copy paste the whole code and changed the icon's color from black to white as you told me.
Note: I have also removed the code from the News Section as well.

I hope this PR is in its ending phase now.

Here are the Results!

l5io · 2024-10-17T07:17:15Z

🚀 Preview for commit 68e48e9 at: https://6710b9a97d9bdaacec91dbd0--layer5.netlify.app

Signed-off-by: THEBOSS0369 <[email protected]>

…yer5 into dark_theme_search

l5io · 2024-10-19T06:02:41Z

🚀 Preview for commit 26dd7b6 at: https://67134b3657a13b407c38a272--layer5.netlify.app

l5io · 2024-10-21T10:56:33Z

🚀 Preview for commit 6884288 at: https://671632d73284890bdad28f2c--layer5.netlify.app

Signed-off-by: THEBOSS0369 <[email protected]>

THEBOSS0369 · 2024-10-22T12:26:00Z

Hey @sudhanshutech @vishalvivekm ! I have done the changes you asked. Please look into it and i hope this is the last thing i needed to change. Thanks

l5io · 2024-10-22T12:36:40Z

🚀 Preview for commit 433f23a at: https://67179bdbb7a10f10183228ff--layer5.netlify.app

l5io · 2024-10-26T11:07:04Z

🚀 Preview for commit 59368e3 at: https://671ccd0237fc879c50759566--layer5.netlify.app

sudhanshutech · 2024-10-29T19:38:22Z

@THEBOSS0369 build is failing

THEBOSS0369 · 2024-10-30T08:00:15Z

@THEBOSS0369 build is failing

@sudhanshutech This issue is not from my side. You can clearly see the build previews link before yesterday. I also checked other PR's tests the build test is failing in those PRs as well.

Signed-off-by: THEBOSS0369 <[email protected]>

THEBOSS0369 · 2024-10-30T08:18:44Z

@vishalvivekm I have moved the code for integration search bar to its own file as you asked me. Please let me know if any changes are needed! Here are the results

vishalvivekm · 2024-10-30T12:11:23Z

@THEBOSS0369 build is failing

@sudhanshutech This issue is not from my side. You can clearly see the build previews link before yesterday. I also checked other PR's tests the build test is failing in those PRs as well.

should be fixed now

l5io · 2024-10-30T12:37:10Z

🚀 Preview for commit ae1c669 at: https://6722282a049c71acb7dc5135--layer5.netlify.app

vishalvivekm · 2024-11-03T13:47:50Z

Thanks much @THEBOSS0369 for your contributions.

THEBOSS0369 · 2024-11-03T14:58:59Z

@vishalvivekm ! Thanks for merging this, now i can work on more issues 😁

Ashparshp and others added 3 commits September 13, 2024 17:03

Mark Senthil Athiban's profile as inactive

111d13b

Signed-off-by: Ashparsh Pandey <[email protected]> Signed-off-by: THEBOSS0369 <[email protected]>

[Docs] Generated documentation for Integration

e02b684

Signed-off-by: l5io <[email protected]> Signed-off-by: THEBOSS0369 <[email protected]>

Merge remote-tracking branch 'upstream/master'

0e75ca7

github-actions bot added the area/core-styles label Sep 15, 2024

Dark Mode Search Input

ae8e3af

Signed-off-by: THEBOSS0369 <[email protected]>

THEBOSS0369 force-pushed the dark_theme_search branch from 7ee7968 to ae8e3af Compare September 15, 2024 11:42

vishalvivekm reviewed Sep 16, 2024

View reviewed changes

src/theme/app/themeStyles.js Outdated

Copy link

Member

vishalvivekm Sep 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We wouldn't want to change theme colors @THEBOSS0369

leecalcote reviewed Sep 17, 2024

View reviewed changes

src/reusecore/Search/searchbox.style.js Outdated Show resolved Hide resolved

Removed issues for default style

b263459

Signed-off-by: THEBOSS0369 <[email protected]>

vishalvivekm requested review from sudhanshutech and hargunkaur286 September 22, 2024 17:08

Added styles in the required file's style page

965b204

Signed-off-by: THEBOSS0369 <[email protected]>

Merge branch 'master' into dark_theme_search

df81b5e

THEBOSS0369 added 3 commits October 17, 2024 12:31

Update resourceGrid.style.js

29c79d1

Signed-off-by: Anuj Kumar Sharma <[email protected]>

Update searchbox.style.js

97d73ae

Signed-off-by: Anuj Kumar Sharma <[email protected]>

Update blogGrid.style.js

68e48e9

Signed-off-by: Anuj Kumar Sharma <[email protected]>

THEBOSS0369 added 2 commits October 19, 2024 11:12

Changed the search icon color

4538208

Signed-off-by: THEBOSS0369 <[email protected]>

Merge branch 'dark_theme_search' of https://github.com/THEBOSS0369/la…

d1b1156

…yer5 into dark_theme_search

Added Boundary on Integration SearchBar

f16f2e9

Signed-off-by: THEBOSS0369 <[email protected]>

THEBOSS0369 force-pushed the dark_theme_search branch from 6884288 to f16f2e9 Compare October 22, 2024 12:19

Moved the integration's search bar code to its own file

75b388c

Signed-off-by: THEBOSS0369 <[email protected]>

THEBOSS0369 force-pushed the dark_theme_search branch from 907a826 to 75b388c Compare October 30, 2024 08:15

Merge branch 'master' into dark_theme_search

b2c6bcd

THEBOSS0369 requested review from vishalvivekm and sudhanshutech October 30, 2024 08:19

Merge branch 'master' into dark_theme_search

ae1c669

Merge branch 'master' into dark_theme_search

8d49b7a

vishalvivekm approved these changes Nov 3, 2024

View reviewed changes

vishalvivekm merged commit 360f670 into layer5io:master Nov 3, 2024
5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Input Search Dark Mode Friendly #5883

Input Search Dark Mode Friendly #5883

THEBOSS0369 commented Sep 15, 2024 •

edited

Loading

l5io commented Sep 15, 2024

Ashparshp commented Sep 16, 2024

vishalvivekm Sep 16, 2024

vishalvivekm commented Sep 16, 2024

vishalvivekm commented Sep 16, 2024

THEBOSS0369 commented Sep 16, 2024

THEBOSS0369 commented Sep 17, 2024

vishalvivekm commented Sep 17, 2024

THEBOSS0369 commented Sep 17, 2024

THEBOSS0369 commented Sep 17, 2024 •

edited

Loading

THEBOSS0369 commented Sep 20, 2024

l5io commented Sep 20, 2024

vishalvivekm commented Sep 22, 2024

vishalvivekm commented Sep 22, 2024 •

edited

Loading

THEBOSS0369 commented Sep 25, 2024 •

edited

Loading

l5io commented Sep 26, 2024

sudhanshutech commented Oct 9, 2024

THEBOSS0369 commented Oct 9, 2024 •

edited

Loading

THEBOSS0369 commented Oct 17, 2024 •

edited

Loading

l5io commented Oct 17, 2024

l5io commented Oct 19, 2024

l5io commented Oct 21, 2024

THEBOSS0369 commented Oct 22, 2024

l5io commented Oct 22, 2024

l5io commented Oct 26, 2024

sudhanshutech commented Oct 29, 2024

THEBOSS0369 commented Oct 30, 2024

THEBOSS0369 commented Oct 30, 2024

vishalvivekm commented Oct 30, 2024

l5io commented Oct 30, 2024

vishalvivekm commented Nov 3, 2024

THEBOSS0369 commented Nov 3, 2024

Input Search Dark Mode Friendly #5883

Input Search Dark Mode Friendly #5883

Conversation

THEBOSS0369 commented Sep 15, 2024 • edited Loading

l5io commented Sep 15, 2024

Ashparshp commented Sep 16, 2024

vishalvivekm Sep 16, 2024

Choose a reason for hiding this comment

vishalvivekm commented Sep 16, 2024

vishalvivekm commented Sep 16, 2024

THEBOSS0369 commented Sep 16, 2024

THEBOSS0369 commented Sep 17, 2024

vishalvivekm commented Sep 17, 2024

THEBOSS0369 commented Sep 17, 2024

THEBOSS0369 commented Sep 17, 2024 • edited Loading

THEBOSS0369 commented Sep 20, 2024

l5io commented Sep 20, 2024

vishalvivekm commented Sep 22, 2024

vishalvivekm commented Sep 22, 2024 • edited Loading

THEBOSS0369 commented Sep 25, 2024 • edited Loading

l5io commented Sep 26, 2024

sudhanshutech commented Oct 9, 2024

THEBOSS0369 commented Oct 9, 2024 • edited Loading

THEBOSS0369 commented Oct 17, 2024 • edited Loading

l5io commented Oct 17, 2024

l5io commented Oct 19, 2024

l5io commented Oct 21, 2024

THEBOSS0369 commented Oct 22, 2024

l5io commented Oct 22, 2024

l5io commented Oct 26, 2024

sudhanshutech commented Oct 29, 2024

THEBOSS0369 commented Oct 30, 2024

THEBOSS0369 commented Oct 30, 2024

vishalvivekm commented Oct 30, 2024

l5io commented Oct 30, 2024

vishalvivekm commented Nov 3, 2024

THEBOSS0369 commented Nov 3, 2024

THEBOSS0369 commented Sep 15, 2024 •

edited

Loading

THEBOSS0369 commented Sep 17, 2024 •

edited

Loading

vishalvivekm commented Sep 22, 2024 •

edited

Loading

THEBOSS0369 commented Sep 25, 2024 •

edited

Loading

THEBOSS0369 commented Oct 9, 2024 •

edited

Loading

THEBOSS0369 commented Oct 17, 2024 •

edited

Loading