Feature/integrations columns #5868

Npcodes1 · 2024-09-07T03:42:10Z

Description

This PR fixes #5514. In the Home section of the src folder, I made edits to the index.js in the Playground-home folder. I added animation so that the icons in the integrations column would shift to a horizontal flow in mobile screen size, while still remaining vertical in tablet/desktop size.

Notes for Reviewers

Signed commits

Yes, I signed my commits.

l5io · 2024-09-07T04:00:32Z

🚀 Preview for commit e4fb8e1 at: https://66dbcf875e74a09f11ebd0e5--layer5.netlify.app

Ashparshp · 2024-09-07T15:50:21Z

@Npcodes1, Thank you for your contribution! Let's discuss this during the website call on Monday at 5:30 PM IST (7:00 AM CT). Please consider adding it as an agenda item to the meeting minutes || meeting link.

Npcodes1 · 2024-09-07T18:39:39Z

@Ashparshp Thank you! I’m unable to make the meeting due to work but should I add it to the minutes anyways to be discussed without me? Also, do I need to worry about the MeshMap Screenshot Service failing?

Ashparshp · 2024-09-07T18:46:45Z

@Npcodes1,

Thank you for your contribution! It’s great to see your updates. If you can’t attend the meeting, please do add the PR to the meeting minutes so it can be discussed in your absence. As for the failing MeshMap Screenshot Service, don’t worry about it—it’s not an issue related to your changes.

Ashparshp · 2024-09-09T12:32:49Z

@Npcodes1, you've done a great job with the changes! Just a small request—please avoid altering linting like spaces or tabs, as it makes it a bit harder to review. It would be helpful to keep only the functional changes.

Npcodes1 · 2024-09-09T13:28:10Z

Ok! Do I need to go make any changes?

Ashparshp · 2024-09-09T14:03:17Z

@Npcodes1, please if you would then just update the functional changes and nothing.

Npcodes1 · 2024-09-10T05:32:54Z

I updated it. Does this look better now? @Ashparshp

l5io · 2024-09-10T05:45:53Z

🚀 Preview for commit e5d7185 at: https://66dfdc7fac854a05d3eeb0d9--layer5.netlify.app

vishalvivekm · 2024-09-10T14:00:27Z

@SAHU-01

Ashparshp

Thank you @Npcodes1, LGTM!

SAHU-01 · 2024-09-13T04:20:50Z

Thank you so much for working on this @Npcodes1 , once you remove the commented code I believe we'll be really close to merging this PR 😉

Npcodes1 · 2024-09-13T23:30:36Z

@SAHU-01 Ok! I made changes but it rejected me using git push because my branch isn't up to date to the main one. It gave these suggestions. Does it matter which one I choose?
git config pull.rebase false # merge
git config pull.rebase true # rebase
git config pull.ff only # fast-forward only

Ashparshp · 2024-09-14T12:14:54Z

@Npcodes1, use git config pull.rebase true.

Npcodes1 · 2024-09-16T06:51:29Z

Ok! Commented code has been removed. Please let me know if I missed anything.

l5io · 2024-09-16T07:07:39Z

🚀 Preview for commit d109db0 at: https://66e7d8fc23e323c810880fd2--layer5.netlify.app

Npcodes1 · 2024-09-16T07:41:22Z

I realized I forgot to sign my commit so I was going to do another commit but now I can't seem to run locally off Gitpod. It's giving me this error:

vishalvivekm · 2024-09-16T11:21:43Z

I realized I forgot to sign my commit so I was going to do another commit but now I can't seem to run locally off Gitpod. It's giving me this error:

please try running make clean

github-actions · 2024-09-16T11:22:19Z

🚨 Alert! Git Police! We couldn’t help but notice that one or more of your commits is missing a sign-off. A what? A commit sign-off (your email address).

To amend the commits in this PR with your signoff using the instructions provided in the DCO check.

To configure your dev environment to automatically signoff on your commits in the future, see these instructions.

Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

github-actions · 2024-09-16T11:22:20Z

🚨 Alert! Git Police! We couldn’t help but notice that one or more of your commits is missing a sign-off. A what? A commit sign-off (your email address).

To amend the commits in this PR with your signoff using the instructions provided in the DCO check.

To configure your dev environment to automatically signoff on your commits in the future, see these instructions.

Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

l5io · 2024-09-17T04:21:09Z

🚀 Preview for commit b9a756c at: https://66e9031e95a9cf7aa5e30ab7--layer5.netlify.app

Signed-off-by: yash37158 <[email protected]> Signed-off-by: Nicole Payne <[email protected]>

Signed-off-by: Lee Calcote <[email protected]> Signed-off-by: Nicole Payne <[email protected]>

Signed-off-by: l5io <[email protected]> Signed-off-by: Nicole Payne <[email protected]>

Bumps [@babel/cli](https://github.com/babel/babel/tree/HEAD/packages/babel-cli) from 7.22.5 to 7.25.6. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.25.6/packages/babel-cli) --- updated-dependencies: - dependency-name: "@babel/cli" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Nicole Payne <[email protected]>

Bumps [react-countdown](https://github.com/ndresx/react-countdown) from 2.3.5 to 2.3.6. - [Release notes](https://github.com/ndresx/react-countdown/releases) - [Commits](ndresx/react-countdown@v2.3.5...v2.3.6) --- updated-dependencies: - dependency-name: react-countdown dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Nicole Payne <[email protected]>

Signed-off-by: Lee Calcote <[email protected]> Signed-off-by: Nicole Payne <[email protected]>

l5io · 2024-09-17T04:59:48Z

🚀 Preview for commit 1bf546b at: https://66e90c6ede7b3f970c80c892--layer5.netlify.app

Npcodes1 · 2024-09-17T05:22:46Z

I fixed it.

Npcodes1 · 2024-09-20T05:25:56Z

@Ashparshp @SAHU-01 @vishalvivekm To resolve the conflicts should I change it to the master version (v0.2.12)?

Ashparshp · 2024-09-20T14:04:45Z

@Npcodes1, Keep the version @v0.2.12

Signed-off-by: Nicole Payne <[email protected]>

l5io · 2024-09-21T03:40:09Z

🚀 Preview for commit 93afc06 at: https://66ee3f803e2f92c861948de0--layer5.netlify.app

Npcodes1 · 2024-09-21T04:35:37Z

@Ashparshp Ok, thanks. Everything's been resolved.

SAHU-01

Looks good to me @Ashparshp and @Npcodes1

SAHU-01 · 2024-09-13T04:15:30Z

src/sections/Home/Playground-home/index.js

-        justify-content: center;
-      }
-    }
+    // @media only screen and (max-width: 700px) {


@Npcodes1 if these lines aren't needed would you mind removing the commented lines altogether?

SAHU-01 · 2024-09-13T04:15:59Z

src/sections/Home/Playground-home/index.js

+            className={
+              imageInView ? "visible container" : "not-visible container"
+            }
+            // className="visible container"


Likewise could you remove this commented line.

SAHU-01 · 2024-09-13T04:17:03Z

src/sections/Home/Playground-home/index.js

-        width: 483px;
-        height: 680px;
-    }
+    // .overlay {


If this overlay style isn't required, could you remove the commented snippets @Npcodes1 ?

@SAHU-01, @Npcodes1, thank you. Let's ignore the comments and merge it for now!

Sorry, I think when I keep updating the branch to get it on par with the main branch something keeps overriding that part because I’ve removed the commented code a few times now and it keeps popping back up lol

Ashparshp · 2024-09-23T11:33:46Z

@vishalvivekm //

Signed-off-by: Nicole Payne <[email protected]>

sudhanshutech · 2024-10-09T10:49:49Z

@Npcodes1 there is update in gatsby now so please kindly re ensure your fix if it still working.

l5io · 2024-10-09T11:06:13Z

🚀 Preview for commit dac708c at: https://6706630f07f33823ee177898--layer5.netlify.app

Npcodes1 · 2024-10-15T01:27:19Z

@Npcodes1 there is update in gatsby now so please kindly re ensure your fix if it still working.

@sudhanshutech Ok. How do I do the update?

leecalcote · 2024-10-15T04:21:41Z

I went ahead and refreshed this branch with latest in the master branch.

@Npcodes1, way to stick with this PR and see it through. 👏 The finish line is in sight! 😄

l5io · 2024-10-15T04:35:58Z

🚀 Preview for commit 1077b7b at: https://670df0e2e3e68c3289cfe2d8--layer5.netlify.app

Npcodes1 force-pushed the feature/integrations-columns branch from d3b6dd4 to e4fb8e1 Compare September 7, 2024 03:45

Ashparshp approved these changes Sep 12, 2024

View reviewed changes

Ashparshp requested a review from hargunkaur286 September 12, 2024 03:51

vishalvivekm added the issue/dco label Sep 16, 2024

Npcodes1 force-pushed the feature/integrations-columns branch from b9a756c to 0c9247c Compare September 17, 2024 04:37

github-actions bot added project/meshery area/news A noteworthy article, event, happening area/blog New posts or new blog functionality area/community area/events labels Sep 17, 2024

yash37158 and others added 9 commits September 17, 2024 04:44

fix: resolve layout inconsistency in CTA_Bottom for mobile screens

8e4592e

Signed-off-by: yash37158 <[email protected]> Signed-off-by: Nicole Payne <[email protected]>

Refactor MeetTheMaintainer import path

4e44b32

Signed-off-by: Lee Calcote <[email protected]> Signed-off-by: Nicole Payne <[email protected]>

Refactor MeetTheMaintainer import path

a775cf0

Signed-off-by: Lee Calcote <[email protected]> Signed-off-by: Nicole Payne <[email protected]>

Refactor import path for MeetTheMaintainer component

c44bfef

Signed-off-by: Lee Calcote <[email protected]> Signed-off-by: Nicole Payne <[email protected]>

Refactor import path for MeetTheMaintainer component

20ad6bb

Signed-off-by: Lee Calcote <[email protected]> Signed-off-by: Nicole Payne <[email protected]>

[Docs] Generated documentation for Integration

c150cde

Signed-off-by: l5io <[email protected]> Signed-off-by: Nicole Payne <[email protected]>

Update meshmap.yml

1bf546b

Signed-off-by: Lee Calcote <[email protected]> Signed-off-by: Nicole Payne <[email protected]>

Npcodes1 force-pushed the feature/integrations-columns branch from 0c9247c to 1bf546b Compare September 17, 2024 04:45

Merge branch 'master' into feature/integrations-columns

93afc06

Signed-off-by: Nicole Payne <[email protected]>

Ashparshp requested a review from SAHU-01 September 23, 2024 07:46

SAHU-01 approved these changes Sep 23, 2024

View reviewed changes

Npcodes1 and others added 4 commits September 25, 2024 03:36

removed additional comments from animation

40dced4

Signed-off-by: Nicole Payne <[email protected]>

added animation comments back

ce888a2

Signed-off-by: Nicole Payne <[email protected]>

Merge branch 'master' into feature/integrations-columns

7dd421e

Merge branch 'master' into feature/integrations-columns

dac708c

Merge branch 'master' into feature/integrations-columns

1077b7b

Feature/integrations columns #5868

Are you sure you want to change the base?

Feature/integrations columns #5868

Conversation

Npcodes1 commented Sep 7, 2024 • edited Loading

l5io commented Sep 7, 2024

Ashparshp commented Sep 7, 2024

Npcodes1 commented Sep 7, 2024

Ashparshp commented Sep 7, 2024

Ashparshp commented Sep 9, 2024

Npcodes1 commented Sep 9, 2024

Ashparshp commented Sep 9, 2024

Npcodes1 commented Sep 10, 2024 • edited Loading

l5io commented Sep 10, 2024

vishalvivekm commented Sep 10, 2024

Ashparshp left a comment

Choose a reason for hiding this comment

SAHU-01 commented Sep 13, 2024

Npcodes1 commented Sep 13, 2024

Ashparshp commented Sep 14, 2024 • edited Loading

Npcodes1 commented Sep 16, 2024

l5io commented Sep 16, 2024

Npcodes1 commented Sep 16, 2024

vishalvivekm commented Sep 16, 2024

github-actions bot commented Sep 16, 2024

github-actions bot commented Sep 16, 2024

l5io commented Sep 17, 2024

l5io commented Sep 17, 2024

Npcodes1 commented Sep 17, 2024

Npcodes1 commented Sep 20, 2024

Ashparshp commented Sep 20, 2024

l5io commented Sep 21, 2024

Npcodes1 commented Sep 21, 2024

SAHU-01 left a comment

Choose a reason for hiding this comment

SAHU-01 Sep 13, 2024

Choose a reason for hiding this comment

SAHU-01 Sep 13, 2024

Choose a reason for hiding this comment

SAHU-01 Sep 13, 2024

Choose a reason for hiding this comment

Ashparshp Sep 23, 2024

Choose a reason for hiding this comment

Npcodes1 Sep 23, 2024

Choose a reason for hiding this comment

Ashparshp commented Sep 23, 2024

sudhanshutech commented Oct 9, 2024

l5io commented Oct 9, 2024

Npcodes1 commented Oct 15, 2024 • edited Loading

leecalcote commented Oct 15, 2024

l5io commented Oct 15, 2024

Npcodes1 commented Sep 7, 2024 •

edited

Loading

Npcodes1 commented Sep 10, 2024 •

edited

Loading

Ashparshp commented Sep 14, 2024 •

edited

Loading

Npcodes1 commented Oct 15, 2024 •

edited

Loading