Fix placeholder text in Text Input component #5769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Preview for commit 2735003 at: https://66ad2ae995b5979fbce46b75--layer5.netlify.app |
Signed-off-by: Siddharth Baleja <[email protected]>
|
🚀 Preview for commit fcdf1ac at: https://66ad342943ec4dab4df6f5e9--layer5.netlify.app |
|
@Ashparshp Can you please review this PR. |
1 similar comment
|
@Ashparshp Can you please review this PR. |
|
@siddharthbaleja7 Thanks for your contribution, let's discuss this on the website's call. Please add this as an agenda item to the meeting minutes. |
sudhanshutech
requested changes
Aug 5, 2024
| @@ -80,7 +80,7 @@ export const TextInputGuidance = () => { | |||
| </p> | |||
| <Row Hcenter> | |||
| <SistentThemeProvider initialMode={isDark ? "dark" : "light"}> | |||
| <Input placeholder="Placeholder goes here" /> | |||
| <Input placeholder="PlaceHolder" /> | |||
There was a problem hiding this comment.
use
Suggested change
| <Input placeholder="PlaceHolder" /> | |
| <Input placeholder="Placeholder" /> |
|
@siddharthbaleja7 there is a small change requested. Will you able to quickly complete that? |
|
@sudhanshutech Sure |
Signed-off-by: siddharthbaleja7 <[email protected]>
|
🚀 Preview for commit 975273a at: https://66b45c24be40e59a6a01572d--layer5.netlify.app |
sudhanshutech
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses an issue with the placeholder text in the Text Input component. The current placeholder text reads "PlaceHolder goes here" when it should be "placeHolder".
Fixes #5738
Expected Behavior
The placeholder text should be updated to display "placeHolder" instead of "PlaceHolder goes here". You can review the component at Sistent Text Input for reference.
Changes Made
Please review the changes and let me know if further adjustments are needed.