Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve issue with cards not fitting on smaller screens in Community Ha… #5768

Merged

Conversation

krishkumar84
Copy link
Contributor

@krishkumar84 krishkumar84 commented Aug 2, 2024

Description

This PR fixes #5639

Notes for Reviewers
@Ashparshp and @sudhanshutech kindly review this

Notes for Reviewers
#5644 its my previous pr and @sudhanshutech want some changes in this to eliminate media queries so i use width and maxwidth property bcz previously size is hardcoded and still and kindly give me the feedback

Signed commits

  • Yes, I signed my commits.

@l5io
Copy link
Contributor

l5io commented Aug 2, 2024

🚀 Preview for commit 19503ca at: https://66acda6943ec4d40b7f78b92--layer5.netlify.app

box-shadow: 0 5px 10px ${props => props.theme.green00D3A9ToGreyE6E6E6};
overflow: hidden;
height: 19rem;
position: relative;
transition: 0.8s cubic-bezier(0.2, 0.8, 0.2, 1);
@media (max-width: 420px) {
font-size: 1rem;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you reducing the font-size?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you reducing the font-size?

hey can you kindly check the code of my updated commit that mediaquery is used to reduce the fontsize of card
image
bcz now it looking like this this text is overflowing thats why i reduce the font size

Signed-off-by: krish <[email protected]>
@l5io
Copy link
Contributor

l5io commented Aug 2, 2024

🚀 Preview for commit e50a365 at: https://66acf1d47275d76da0978676--layer5.netlify.app

@Ashparshp
Copy link
Contributor

@krishkumar84 Thanks for your contribution, let's discuss this on the website's call. Please add this as an agenda item to the meeting minutes.

@Ashparshp
Copy link
Contributor

@krishkumar84, is it updated with the recent suggestions from the last meeting? I don't see any commits afterward, so is there anything you would like to update? or is it completed?

@krishkumar84
Copy link
Contributor Author

hi @Ashparshp i update it with suggestion and discuss in meeting and also @sudhanshutech review this i made changes acc to previous discussion like using the combination of max-width and width and all changes are good that's why i am waiting for it to merge this pr

Copy link
Contributor

@Ashparshp Ashparshp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @krishkumar84.

@Ashparshp
Copy link
Contributor

@sudhanshutech //

@sudhanshutech sudhanshutech merged commit a3751ba into layer5io:master Aug 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Cards not fitting on smaller screens in Community Handbook page
4 participants