-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solve issue with cards not fitting on smaller screens in Community Ha… #5768
Solve issue with cards not fitting on smaller screens in Community Ha… #5768
Conversation
…ndbook page Signed-off-by: krish <[email protected]>
🚀 Preview for commit 19503ca at: https://66acda6943ec4d40b7f78b92--layer5.netlify.app |
box-shadow: 0 5px 10px ${props => props.theme.green00D3A9ToGreyE6E6E6}; | ||
overflow: hidden; | ||
height: 19rem; | ||
position: relative; | ||
transition: 0.8s cubic-bezier(0.2, 0.8, 0.2, 1); | ||
@media (max-width: 420px) { | ||
font-size: 1rem; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you reducing the font-size?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: krish <[email protected]>
🚀 Preview for commit e50a365 at: https://66acf1d47275d76da0978676--layer5.netlify.app |
@krishkumar84 Thanks for your contribution, let's discuss this on the website's call. Please add this as an agenda item to the meeting minutes. |
@krishkumar84, is it updated with the recent suggestions from the last meeting? I don't see any commits afterward, so is there anything you would like to update? or is it completed? |
hi @Ashparshp i update it with suggestion and discuss in meeting and also @sudhanshutech review this i made changes acc to previous discussion like using the combination of max-width and width and all changes are good that's why i am waiting for it to merge this pr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you @krishkumar84.
Description
This PR fixes #5639
Notes for Reviewers
@Ashparshp and @sudhanshutech kindly review this
Notes for Reviewers
#5644 its my previous pr and @sudhanshutech want some changes in this to eliminate media queries so i use width and maxwidth property bcz previously size is hardcoded and still and kindly give me the feedback
Signed commits