-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added phrases #5761
base: master
Are you sure you want to change the base?
Added phrases #5761
Conversation
Signed-off-by: Hargun Kaur <[email protected]>
🚀 Preview for commit a749288 at: https://66ac11228362b37c8952e120--layer5.netlify.app |
src/sections/Meshery/index.js
Outdated
@@ -62,6 +62,7 @@ const MesheryPage = () => { | |||
image={Nic} /> | |||
<div className="callout"> | |||
<h1> Manage your clusters with features you won't find anywhere else.</h1> | |||
<h4><strong>Illustrate key concepts with visuals. </strong>Use diagrams, charts, or images to help users grasp complex ideas quickly.</h4> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about making it italic? It doesn't look good here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or perhaps not using a strong tag?
@hargunkaur286 Thanks for your contribution, let's discuss this on the website's call. Please add this as an agenda item to the meeting minutes. |
@hargunkaur286, any updates on this? How are we going to proceed with it, or is it on hold? |
@hargunkaur286 please make the updates here as requested. |
Signed-off-by: Hargun Kaur <[email protected]>
Signed-off-by: Hargun Kaur <[email protected]>
🚀 Preview for commit 29a5642 at: https://66c0aece9b90ff7b2bd8d4a3--layer5.netlify.app |
Signed-off-by: Hargun Kaur <[email protected]>
🚀 Preview for commit b3e3282 at: https://66c0b257d9e6ac7d77738ff9--layer5.netlify.app |
Thank you @hargunkaur286 ^^ Looks good to me
for the meshmap page, I wonder if adding the phrase next to the already long description fails to make it stand out as intended. |
Also, getting one / more of these phrases on Homepage would be nice. |
Signed-off-by: Hargun Kaur <[email protected]>
🚀 Preview for commit 007dfd3 at: https://66c32e325b098bb2ecea1e34--layer5.netlify.app |
merge conflicts. |
Description
Changes made in the following files:
This PR fixes #
Notes for Reviewers
Signed commits