Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added phrases #5761

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Added phrases #5761

wants to merge 5 commits into from

Conversation

hargunkaur286
Copy link
Member

@hargunkaur286 hargunkaur286 commented Aug 1, 2024

Description
Changes made in the following files:

  1. In https://layer5.io/cloud-native-management/meshery page:
Cloud Native Application Management Manage your clusters with features you won't find
  1. In https://layer5.io/cloud-native-management/meshmap page:
Step aside, YAML
  1. In https://layer5.io/cloud-native-management/catalog page:
CREATE AND SHARE YOUR OWN

This PR fixes #

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@l5io
Copy link
Contributor

l5io commented Aug 1, 2024

🚀 Preview for commit a749288 at: https://66ac11228362b37c8952e120--layer5.netlify.app

@@ -62,6 +62,7 @@ const MesheryPage = () => {
image={Nic} />
<div className="callout">
<h1> Manage your clusters with features you won't find anywhere else.</h1>
<h4><strong>Illustrate key concepts with visuals. </strong>Use diagrams, charts, or images to help users grasp complex ideas quickly.</h4>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about making it italic? It doesn't look good here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or perhaps not using a strong tag?

@Ashparshp
Copy link
Contributor

@hargunkaur286 Thanks for your contribution, let's discuss this on the website's call. Please add this as an agenda item to the meeting minutes.

@Ashparshp
Copy link
Contributor

Ashparshp commented Aug 13, 2024

@hargunkaur286, any updates on this? How are we going to proceed with it, or is it on hold?

@sudhanshutech
Copy link
Member

@hargunkaur286 please make the updates here as requested.

Signed-off-by: Hargun Kaur <[email protected]>
Signed-off-by: Hargun Kaur <[email protected]>
@l5io
Copy link
Contributor

l5io commented Aug 17, 2024

🚀 Preview for commit 29a5642 at: https://66c0aece9b90ff7b2bd8d4a3--layer5.netlify.app

Signed-off-by: Hargun Kaur <[email protected]>
@l5io
Copy link
Contributor

l5io commented Aug 17, 2024

🚀 Preview for commit b3e3282 at: https://66c0b257d9e6ac7d77738ff9--layer5.netlify.app

@vishalvivekm
Copy link
Member

Thank you @hargunkaur286

  1. Playground page ✔️
    image

^^ Looks good to me


  1. Catalog Page:
    image
    I'm not sure if the added phrase fits into the context (CREATE AND SHARE YOUR OWN BEST PRACTICES)

  1. MeshMap page [Your screenshot]
    image

for the meshmap page, I wonder if adding the phrase next to the already long description fails to make it stand out as intended.
Note: https://66c0aece9b90ff7b2bd8d4a3--layer5.netlify.app/cloud-native-management/meshmap I can't see the added phrase in preview.

@vishalvivekm
Copy link
Member

Also, getting one / more of these phrases on Homepage would be nice.

Signed-off-by: Hargun Kaur <[email protected]>
@l5io
Copy link
Contributor

l5io commented Aug 19, 2024

🚀 Preview for commit 007dfd3 at: https://66c32e325b098bb2ecea1e34--layer5.netlify.app

@hargunkaur286
Copy link
Member Author

Screenshot 2024-08-19 at 5 52 32 PM Screenshot 2024-08-19 at 5 53 10 PM

@vishalvivekm
Copy link
Member

merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

6 participants