-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Slider unresponsiveness for smaller width #5706
Conversation
Signed-off-by: Saurav Upadhyay <[email protected]>
🚀 Preview for commit 8a30198 at: https://669c214459d015307760b2c3--layer5.netlify.app |
Thanks, @upsaurav12! 🎈 |
@upsaurav12 Kindly elaborate the issue in detail and properly. Your point is not clear in the commit or in PR. There are couple of issues that I can see in your commit attached video. What is the issue that you are targeting? In Live Preview: Slider is unresponsive, we got horizontal scrolling/extra left-side space issue, Meshmap CTA is unresponsive. We have meeting on Monday regarding Website discussion, I'll suggest you to join that as well. https://layer5.io/community/calendar |
@Muhammed-Moinuddin can you tell me at which media query the slider is unresponsive like when i see in |
@upsaurav12 Thanks for your contribution, let's discuss this on the website's call. Please add this as an agenda item to the meeting minutes. |
Issue description that you've attached with PR created confusion. Yup, I got your point. |
Hi @Muhammed-Moinuddin any update? |
🚀 Preview for commit 2862fa7 at: https://66a66d1e9788dc4edb19639d--layer5.netlify.app |
@upsaurav12 To me, it is same like we are having currently on live website. |
@Muhammed-Moinuddin oh i see whats the confusion the problem was that(from my end) that if you to the website and see the slider and change the width size it will.be unresponsive(elements are going outside) but if you see.this in local host then it will take some time to change from the unresponsive to responsive so i have change that cinnamon-2024-07-29T0922160530.mp4 |
Hi @Muhammed-Moinuddin, are still facing the same problem?? from my end everything seems to be fine |
🚀 Preview for commit 4a1600c at: https://66acc9e49e097e39dded7e2a--layer5.netlify.app |
@upsaurav12 Your PR is just a logic enhancement and this issue is not considered valid as well please check: #5724 (comment) There might be some other aspects causing it, but your PR is not about those. |
@Muhammed-Moinuddin |
Yup you can close them. |
Description
This PR fixes #5670
Notes for Reviewers
In this PR i have changed some properties like
no of slides
in each breakpoints by usinguse state
because it was taking long time to render correct styling . so by using this method we can see the changes at the same time we are changing the widthSigned commits